From f05d4b68a282e5edbc469a540da0ff5c295c347e Mon Sep 17 00:00:00 2001 From: Kiara Navarro Date: Sat, 18 Jun 2022 11:29:21 -0500 Subject: [PATCH 1/3] issue: implement issue forms Signed-off-by: Kiara Navarro --- .github/ISSUE_TEMPLATE/bugreport.yaml | 59 ++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/config.yml | 5 ++ .github/ISSUE_TEMPLATE/featurequest.yaml | 46 ++++++++++++++++++ 3 files changed, 110 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bugreport.yaml create mode 100644 .github/ISSUE_TEMPLATE/config.yml create mode 100644 .github/ISSUE_TEMPLATE/featurequest.yaml diff --git a/.github/ISSUE_TEMPLATE/bugreport.yaml b/.github/ISSUE_TEMPLATE/bugreport.yaml new file mode 100644 index 0000000..9ba5bd4 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bugreport.yaml @@ -0,0 +1,59 @@ +name: Bug report +description: Create a report to spot probably hidden bugs :) +labels: ["bug :bug:"] + +body: +- type: markdown + attributes: + value: | + It's not an everyday experience when you found that there is a Vector Network Analyzer + open hardware and source available for you to use it but also study it and improve it. + + **If you came here, we really appreciate your time in wanting to report a bug.** + + Before actually start typing, please double check that there are not already existing + issues related to this bug, including open and closed. + +- type: textarea + attributes: + label: LibreVNA Version + description: Go to LibreVNA app -> Help -> About menu and hit "To clipboard". Paste info in this field + placeholder: | + LibreVNA Version (64 bit): 1.3.0-d701ed64d + OS: Fedora Linux 36 (Workstation Edition) + CPU Arch: x86_64 + validations: + required: true + +- type: textarea + attributes: + label: Steps to reproduce + description: Describe what are the procedures to actually make the bug appears + placeholder: | + - LibreVNA app is launched + - LibreVNA device is connected throughout app + - When using VNA mode... + validations: + required: true + +- type: textarea + attributes: + label: Expected behavior + description: What are the results you would expect it + validations: + required: true + +- type: textarea + attributes: + label: Extra information & Setup and Calibration files + description: Any information that you may find would be relevant and that doesn´t fit + in other fields + validations: + required: true + +- type: checkboxes + attributes: + label: Confirming that you haven´t forgot to include configuration files + options: + - label: Setup file + - label: Calibration file diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 0000000..7dbce8b --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,5 @@ +blank_issues_enabled: false +contact_links: + - name: Community support + url: https://groups.io/g/LibreVNA-support/ + about: For general questions or discussions. diff --git a/.github/ISSUE_TEMPLATE/featurequest.yaml b/.github/ISSUE_TEMPLATE/featurequest.yaml new file mode 100644 index 0000000..309bce3 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/featurequest.yaml @@ -0,0 +1,46 @@ +name: Feature request +description: Suggest new functionality +labels: ["feature ::sparkles:"] + +body: +- type: markdown + attributes: + value: | + It's not an everyday experience when you found that there is a Vector Network Analyzer + open hardware and source available for you to use it but also study it and improve it. + + **If you came here, we really appreciate your time in wanting to discuss how a new + feature can be integrated.** + + Before actually start typing, please double check that there are not already existing + issues related to this bug, including open and closed. + +- type: textarea + attributes: + label: Summary + description: Describe what's the funcionality you aiming to suggest + validations: + required: true + +- type: textarea + attributes: + label: Paths to implement it + description: Describe in which way your suggestion can be achieved + validations: + required: true + +- type: textarea + attributes: + label: Extra information & Setup and Calibration files + description: Any information that you may find would be relevant and that doesn´t fit + in other fields + validations: + required: true + +- type: checkboxes + attributes: + label: Confirming that you haven´t forgot to include configuration files + options: + - label: Setup file + - label: Calibration file + From 051aed0e130594222cb657aedf7aa530177fa4c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20K=C3=A4berich?= Date: Sun, 19 Jun 2022 12:22:53 +0200 Subject: [PATCH 2/3] issue templates suggested changes --- .github/ISSUE_TEMPLATE/bugreport.yaml | 10 ++++------ .github/ISSUE_TEMPLATE/featurequest.yaml | 15 +++------------ 2 files changed, 7 insertions(+), 18 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bugreport.yaml b/.github/ISSUE_TEMPLATE/bugreport.yaml index 9ba5bd4..e55e014 100644 --- a/.github/ISSUE_TEMPLATE/bugreport.yaml +++ b/.github/ISSUE_TEMPLATE/bugreport.yaml @@ -6,9 +6,6 @@ body: - type: markdown attributes: value: | - It's not an everyday experience when you found that there is a Vector Network Analyzer - open hardware and source available for you to use it but also study it and improve it. - **If you came here, we really appreciate your time in wanting to report a bug.** Before actually start typing, please double check that there are not already existing @@ -28,7 +25,7 @@ body: - type: textarea attributes: label: Steps to reproduce - description: Describe what are the procedures to actually make the bug appears + description: Describe the procedures to actually make the bug appears placeholder: | - LibreVNA app is launched - LibreVNA device is connected throughout app @@ -39,7 +36,7 @@ body: - type: textarea attributes: label: Expected behavior - description: What are the results you would expect it + description: What are the results you would expect validations: required: true @@ -53,7 +50,8 @@ body: - type: checkboxes attributes: - label: Confirming that you haven´t forgot to include configuration files + label: Confirming that you haven´t forgot to include configuration files (if applicable) options: - label: Setup file - label: Calibration file + - label: Touchstone file of measurements diff --git a/.github/ISSUE_TEMPLATE/featurequest.yaml b/.github/ISSUE_TEMPLATE/featurequest.yaml index 309bce3..a62265a 100644 --- a/.github/ISSUE_TEMPLATE/featurequest.yaml +++ b/.github/ISSUE_TEMPLATE/featurequest.yaml @@ -5,15 +5,12 @@ labels: ["feature ::sparkles:"] body: - type: markdown attributes: - value: | - It's not an everyday experience when you found that there is a Vector Network Analyzer - open hardware and source available for you to use it but also study it and improve it. - + value: | **If you came here, we really appreciate your time in wanting to discuss how a new feature can be integrated.** Before actually start typing, please double check that there are not already existing - issues related to this bug, including open and closed. + issues related to this feature, including open and closed. - type: textarea attributes: @@ -31,16 +28,10 @@ body: - type: textarea attributes: - label: Extra information & Setup and Calibration files + label: Extra information description: Any information that you may find would be relevant and that doesn´t fit in other fields validations: required: true -- type: checkboxes - attributes: - label: Confirming that you haven´t forgot to include configuration files - options: - - label: Setup file - - label: Calibration file From 401a140449bb87d61fd1ab4b3f0dfafb0b5212c8 Mon Sep 17 00:00:00 2001 From: Kiara Navarro Date: Mon, 20 Jun 2022 17:35:38 -0500 Subject: [PATCH 3/3] main/app: move message pattern to main --- Software/PC_Application/appwindow.cpp | 2 -- Software/PC_Application/main.cpp | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Software/PC_Application/appwindow.cpp b/Software/PC_Application/appwindow.cpp index 2b1e836..d5513bb 100644 --- a/Software/PC_Application/appwindow.cpp +++ b/Software/PC_Application/appwindow.cpp @@ -75,8 +75,6 @@ AppWindow::AppWindow(QWidget *parent) , appVersion(APP_VERSION) , appGitHash(APP_GIT_HASH) { - qSetMessagePattern("%{time process}: [%{type}] %{message}"); - // qDebug().setVerbosity(0); qDebug() << "Application start"; diff --git a/Software/PC_Application/main.cpp b/Software/PC_Application/main.cpp index d1217c6..a18baa9 100644 --- a/Software/PC_Application/main.cpp +++ b/Software/PC_Application/main.cpp @@ -17,6 +17,9 @@ static void tryExitGracefully(int s) { #endif int main(int argc, char *argv[]) { + + qSetMessagePattern("%{time process}: [%{type}] %{message}"); + app = new QApplication(argc, argv); QCoreApplication::setOrganizationName("LibreVNA"); QCoreApplication::setApplicationName("LibreVNA-GUI");