caiyu/LibreVNA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app: refactor enable connect to

Browse Source 
Instead of enabling multiple times "connect to" by iterating
over device list, let's use a flag that determine when at
least one device was found. In that way, the enabling method
is executed once.
This commit is contained in:
Kiara Navarro 2022-07-14 07:48:25 -05:00
parent b420dc3019
commit 8ea6345e9f
No known key found for this signature in database
GPG Key ID: CBA9F2172CE33FBA
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Software/PC_Application/appwindow.cpp
View File

@ -932,6 +932,7 @@ int AppWindow::UpdateDeviceList()
devices.insert(device->serial()); devices.insert(device->serial());
} }
int available = 0; int available = 0;
bool found = false;
if(devices.size()) { if(devices.size()) {
for(auto d : devices) { for(auto d : devices) {
if(!parser.value("device").isEmpty() && parser.value("device") != d) { if(!parser.value("device").isEmpty() && parser.value("device") != d) {
@ -947,13 +948,11 @@ int AppWindow::UpdateDeviceList()
connect(connectAction, &QAction::triggered, [this, d]() { connect(connectAction, &QAction::triggered, [this, d]() {
ConnectToDevice(d); ConnectToDevice(d);
}); });
ui->menuConnect_to->setEnabled(true); found = true;
available++; available++;
} }
} else {
// no devices available, disable connection option
ui->menuConnect_to->setEnabled(false);
} }
ui->menuConnect_to->setEnabled(found);
qDebug() << "Updated device list, found" << available; qDebug() << "Updated device list, found" << available;
return available; return available;
} }