Minor pull-request adjustments

- Restore active mode after amplitude calibration
- Keep order of modes as before (must users are probably used to that order by now)
- Use correct parent for name popup when creating new modes
This commit is contained in:
Jan Käberich 2022-07-17 15:39:13 +02:00
parent 2a4850caf6
commit d516d1ae41
5 changed files with 6 additions and 6 deletions

View File

@ -25,7 +25,7 @@ AmplitudeCalDialog::AmplitudeCalDialog(Device *dev, ModeHandler *handler, QWidge
model(this), model(this),
mode(CalibrationMode::BothPorts) mode(CalibrationMode::BothPorts)
{ {
auto activeMode = modeHandler->getActiveMode(); activeMode = modeHandler->getActiveMode();
modeHandler->deactivate(activeMode); modeHandler->deactivate(activeMode);
dev->SetIdle(); dev->SetIdle();
ui->setupUi(this); ui->setupUi(this);
@ -138,7 +138,6 @@ AmplitudeCalDialog::AmplitudeCalDialog(Device *dev, ModeHandler *handler, QWidge
AmplitudeCalDialog::~AmplitudeCalDialog() AmplitudeCalDialog::~AmplitudeCalDialog()
{ {
delete ui; delete ui;
auto activeMode = modeHandler->getActiveMode();
modeHandler->activate(activeMode); modeHandler->activate(activeMode);
} }

View File

@ -101,6 +101,7 @@ protected:
std::vector<CorrectionPoint> points; std::vector<CorrectionPoint> points;
Ui::AmplitudeCalDialog *ui; Ui::AmplitudeCalDialog *ui;
Device *dev; Device *dev;
Mode *activeMode;
ModeHandler *modeHandler; ModeHandler *modeHandler;
AmplitudeModel model; AmplitudeModel model;
bool edited; bool edited;

View File

@ -238,8 +238,8 @@ AppWindow::AppWindow(QWidget *parent)
setCentralWidget(central); setCentralWidget(central);
auto vnaIndex = modeHandler->createMode("Vector Network Analyzer", Mode::Type::VNA); auto vnaIndex = modeHandler->createMode("Vector Network Analyzer", Mode::Type::VNA);
modeHandler->createMode("Spectrum Analyzer", Mode::Type::SA);
modeHandler->createMode("Signal Generator", Mode::Type::SG); modeHandler->createMode("Signal Generator", Mode::Type::SG);
modeHandler->createMode("Spectrum Analyzer", Mode::Type::SA);
modeHandler->setCurrentIndex(vnaIndex); modeHandler->setCurrentIndex(vnaIndex);
auto setModeStatusbar = [=](const QString &msg) { auto setModeStatusbar = [=](const QString &msg) {

View File

@ -8,8 +8,8 @@
#include <QPushButton> #include <QPushButton>
#include <QMenuBar> #include <QMenuBar>
ModeWindow::ModeWindow(ModeHandler* handler, AppWindow* aw, QWidget* parent): ModeWindow::ModeWindow(ModeHandler* handler, AppWindow* aw):
QWidget(parent), QWidget(aw),
handler(handler), handler(handler),
aw(aw) aw(aw)
{ {

View File

@ -7,7 +7,7 @@ class ModeWindow: public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
explicit ModeWindow(ModeHandler* handler, AppWindow* aw, QWidget *parent = nullptr); explicit ModeWindow(ModeHandler* handler, AppWindow* aw);
~ModeWindow(); ~ModeWindow();
private: private: