caiyu/gmio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use = {0} init instead of memset() where applicable

Browse Source
This commit is contained in:
Hugues Delorme 2014-11-19 09:41:10 +01:00
parent 5c959616aa
commit 4fa3e7f380
3 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/gmio_stl/stlb_read.c
View File

@ -49,7 +49,7 @@ int gmio_stlb_read(gmio_stl_mesh_creator_t *creator,
gmio_endianness_t byte_order) gmio_endianness_t byte_order)
{ {
const gmio_endianness_t host_byte_order = gmio_host_endianness(); const gmio_endianness_t host_byte_order = gmio_host_endianness();
gmio_stlb_readwrite_helper_t rparams; gmio_stlb_readwrite_helper_t rparams = {0};
uint8_t header_data[GMIO_STLB_HEADER_SIZE]; uint8_t header_data[GMIO_STLB_HEADER_SIZE];
uint32_t total_facet_count = 0; /* Count of facets as declared in the stream */ uint32_t total_facet_count = 0; /* Count of facets as declared in the stream */
int error = GMIO_NO_ERROR; /* Helper variable to store function result error code */ int error = GMIO_NO_ERROR; /* Helper variable to store function result error code */
@ -59,7 +59,6 @@ int gmio_stlb_read(gmio_stl_mesh_creator_t *creator,
return error; return error;
/* Initialize rparams */ /* Initialize rparams */
memset(&rparams, 0, sizeof(gmio_stlb_readwrite_helper_t));
if (host_byte_order != byte_order) if (host_byte_order != byte_order)
rparams.fix_endian_func = gmio_stl_triangle_bswap; rparams.fix_endian_func = gmio_stl_triangle_bswap;

3
src/gmio_stl/stlb_write.c
View File

@ -47,7 +47,7 @@ int gmio_stlb_write(const gmio_stl_mesh_t *mesh,
const uint8_t *header_data, const uint8_t *header_data,
gmio_endianness_t byte_order) gmio_endianness_t byte_order)
{ {
gmio_stlb_readwrite_helper_t wparams; gmio_stlb_readwrite_helper_t wparams = {0};
const uint32_t facet_count = mesh != NULL ? mesh->triangle_count : 0; const uint32_t facet_count = mesh != NULL ? mesh->triangle_count : 0;
uint32_t i_facet = 0; uint32_t i_facet = 0;
int error = GMIO_NO_ERROR; int error = GMIO_NO_ERROR;
@ -59,7 +59,6 @@ int gmio_stlb_write(const gmio_stl_mesh_t *mesh,
return error; return error;
/* Initialize wparams */ /* Initialize wparams */
memset(&wparams, 0, sizeof(gmio_stlb_readwrite_helper_t));
if (gmio_host_endianness() != byte_order) if (gmio_host_endianness() != byte_order)
wparams.fix_endian_func = gmio_stl_triangle_bswap; wparams.fix_endian_func = gmio_stl_triangle_bswap;
wparams.facet_count = trsf->buffer_size / GMIO_STLB_TRIANGLE_RAWSIZE; wparams.facet_count = trsf->buffer_size / GMIO_STLB_TRIANGLE_RAWSIZE;

7
tests/test_internal.c
View File

@ -47,12 +47,12 @@ const char* test_internal__ascii_parse()
"pi : 3.1415926535897932384626433832795"; "pi : 3.1415926535897932384626433832795";
{ {
gmio_buffer_t buff; gmio_buffer_t buff = {0};
gmio_stream_t stream; gmio_stream_t stream = {0};
char small_fwd_it_str[4]; char small_fwd_it_str[4];
char fwd_it_str[32]; char fwd_it_str[32];
gmio_ascii_stream_fwd_iterator_t fwd_it; gmio_ascii_stream_fwd_iterator_t fwd_it = {0};
char copy_str[128]; char copy_str[128];
gmio_ascii_string_buffer_t copy_strbuff; gmio_ascii_string_buffer_t copy_strbuff;
@ -62,7 +62,6 @@ const char* test_internal__ascii_parse()
buff.pos = 0; buff.pos = 0;
gmio_stream_set_buffer(&stream, &buff); gmio_stream_set_buffer(&stream, &buff);
memset(&fwd_it, 0, sizeof(gmio_ascii_stream_fwd_iterator_t));
fwd_it.stream = &stream; fwd_it.stream = &stream;
fwd_it.buffer.ptr = fwd_it_str; fwd_it.buffer.ptr = fwd_it_str;
fwd_it.buffer.max_len = sizeof(fwd_it_str); fwd_it.buffer.max_len = sizeof(fwd_it_str);