caiyu/gmio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gmio_stl: fix sprintf() format issue

Browse Source
This commit is contained in:
Hugues Delorme 2015-03-18 16:27:43 +01:00
parent d137aac506
commit 71b9faff4f
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CMakeLists.txt
View File

@ -82,6 +82,7 @@ if(MSVC)
# Set warning level to /W4 # Set warning level to /W4
string(REGEX REPLACE "/W[0-9]" "/W4" CMAKE_C_FLAGS ${CMAKE_C_FLAGS}) string(REGEX REPLACE "/W[0-9]" "/W4" CMAKE_C_FLAGS ${CMAKE_C_FLAGS})
#set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /analyze")
# Treat warnings as errors # Treat warnings as errors
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /WX") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /WX")

16
src/gmio_stl/stla_write.c
View File

@ -93,7 +93,7 @@ static char* gmio_write_stdio_format(char* buffer, uint8_t prec)
buffer[0] = '%'; buffer[0] = '%';
buffer[1] = '.'; buffer[1] = '.';
prec_len = sprintf(buffer + 2, "%i", prec); prec_len = sprintf(buffer + 2, "%u", prec);
buffer[2 + prec_len] = 'E'; buffer[2 + prec_len] = 'E';
return buffer + 3 + prec_len; return buffer + 3 + prec_len;
} }
@ -131,14 +131,14 @@ int gmio_stla_write(const gmio_stl_mesh_t* mesh,
int error = GMIO_NO_ERROR; int error = GMIO_NO_ERROR;
/* Check validity of input parameters */ /* Check validity of input parameters */
gmio_check_transfer(&error, trsf); if (!gmio_check_transfer(&error, trsf))
gmio_stl_check_mesh(&error, mesh);
if (float32_prec == 0 || float32_prec > 9)
error = GMIO_STLA_WRITE_INVALID_REAL32_PREC_ERROR;
if (trsf->buffer_size < GMIO_STLA_FACET_SIZE_P2)
error = GMIO_INVALID_BUFFER_SIZE_ERROR;
if (gmio_error(error))
return error; return error;
if (!gmio_stl_check_mesh(&error, mesh))
return error;
if (float32_prec == 0 || float32_prec > 9)
return GMIO_STLA_WRITE_INVALID_REAL32_PREC_ERROR;
if (trsf->buffer_size < GMIO_STLA_FACET_SIZE_P2)
return GMIO_INVALID_BUFFER_SIZE_ERROR;
{ /* Create XYZ coords format string (for normal and vertex coords) */ { /* Create XYZ coords format string (for normal and vertex coords) */
char* coords_format_iterator = coords_format; char* coords_format_iterator = coords_format;