caiyu/gmio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: fix resource leaks in test_stl_io.c

Browse Source
This commit is contained in:
Hugues Delorme 2015-11-06 15:29:29 +01:00
parent 02e7508ee6
commit c800b4afc3
1 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/test_stl_io.c
View File

@ -213,6 +213,15 @@ const char* test_stlb_write_header()
return NULL; return NULL;
} }
/* Safely closes the two files \p f1 and \p f2 */
static void fclose_2(FILE* f1, FILE* f2)
{
if (f1 != NULL)
fclose(f1);
if (f2 != NULL)
fclose(f2);
}
const char* test_stlb_write() const char* test_stlb_write()
{ {
const char* model_filepath = stl_grabcad_arm11_filepath; const char* model_filepath = stl_grabcad_arm11_filepath;
@ -253,14 +262,25 @@ const char* test_stlb_write()
size_t bytes_read_out = 0; size_t bytes_read_out = 0;
FILE* in = fopen(model_filepath, "rb"); FILE* in = fopen(model_filepath, "rb");
FILE* out = fopen(model_filepath_out, "rb"); FILE* out = fopen(model_filepath_out, "rb");
UTEST_ASSERT(in != NULL && out != NULL); if (in == NULL || out == NULL) {
fclose_2(in, out);
perror("test_stlb_write()");
UTEST_FAIL("fopen() error for in/out model files");
}
do { do {
bytes_read_in = fread(&buffer_in[0], 1, buff_size, in); bytes_read_in = fread(&buffer_in[0], 1, buff_size, in);
bytes_read_out = fread(&buffer_out[0], 1, buff_size, out); bytes_read_out = fread(&buffer_out[0], 1, buff_size, out);
UTEST_ASSERT(bytes_read_in == bytes_read_out); if (bytes_read_in != bytes_read_out) {
UTEST_ASSERT(memcmp(&buffer_in[0], &buffer_out[0], buff_size) == 0); fclose_2(in, out);
UTEST_FAIL("Different byte count between in/out");
}
if (memcmp(&buffer_in[0], &buffer_out[0], buff_size) != 0) {
fclose_2(in, out);
UTEST_FAIL("Different buffer contents between in/out");
}
} while (!feof(in) && !feof(out) } while (!feof(in) && !feof(out)
&& bytes_read_in > 0 && bytes_read_out > 0); && bytes_read_in > 0 && bytes_read_out > 0);
fclose_2(in, out);
} }
/* Check output LE/BE models are equal */ /* Check output LE/BE models are equal */