From 3d4f1dc60b954bd266853185b63a488b23287e97 Mon Sep 17 00:00:00 2001 From: Michael Buesch Date: Mon, 20 May 2019 22:17:45 +0200 Subject: [PATCH] gui: Fix warning: catching polymorphic type by value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gui/application.cc: In member function ‘virtual bool nextpnr_ice40::Application::notify(QObject*, QEvent*)’: gui/application.cc:56:32: warning: catching polymorphic type ‘class nextpnr_ice40::assertion_failure’ by value [-Wcatch-value=] --- gui/application.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gui/application.cc b/gui/application.cc index 7751e6f1..8c3db77b 100644 --- a/gui/application.cc +++ b/gui/application.cc @@ -53,7 +53,7 @@ bool Application::notify(QObject *receiver, QEvent *event) bool retVal = true; try { retVal = QApplication::notify(receiver, event); - } catch (assertion_failure ex) { + } catch (const assertion_failure &ex) { QString msg; QTextStream out(&msg); out << ex.filename.c_str() << " at " << ex.line << "\n";