From a58735bc57ae68043a20ab694c0526df9275268c Mon Sep 17 00:00:00 2001 From: Catherine Date: Sat, 11 Jan 2025 21:43:32 +0000 Subject: [PATCH] himbaechel: add missing `override` qualifiers. --- himbaechel/uarch/example/example.cc | 6 +++--- himbaechel/uarch/gowin/gowin.cc | 6 +++--- himbaechel/uarch/ng-ultra/ng_ultra.cc | 2 +- himbaechel/uarch/xilinx/xilinx.cc | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/himbaechel/uarch/example/example.cc b/himbaechel/uarch/example/example.cc index cfb2a0b9..4eebb5ba 100644 --- a/himbaechel/uarch/example/example.cc +++ b/himbaechel/uarch/example/example.cc @@ -194,7 +194,7 @@ struct ExampleImpl : HimbaechelAPI } void drawWire(std::vector &g, GraphicElement::style_t style, Loc loc, IdString wire_type, - int32_t tilewire, IdString tile_type) + int32_t tilewire, IdString tile_type) override { GraphicElement el; el.type = GraphicElement::TYPE_LINE; @@ -308,7 +308,7 @@ struct ExampleImpl : HimbaechelAPI } void drawPip(std::vector &g, GraphicElement::style_t style, Loc loc, WireId src, IdString src_type, - int32_t src_id, WireId dst, IdString dst_type, int32_t dst_id) + int32_t src_id, WireId dst, IdString dst_type, int32_t dst_id) override { GraphicElement el; el.type = GraphicElement::TYPE_ARROW; @@ -329,7 +329,7 @@ struct ExampleArch : HimbaechelArch { ExampleArch() : HimbaechelArch("example") {}; bool match_device(const std::string &device) override { return device == "EXAMPLE"; } - std::unique_ptr create(const std::string &device, const dict &args) + std::unique_ptr create(const std::string &device, const dict &args) override { return std::make_unique(); } diff --git a/himbaechel/uarch/gowin/gowin.cc b/himbaechel/uarch/gowin/gowin.cc index 56e0d103..7ec19123 100644 --- a/himbaechel/uarch/gowin/gowin.cc +++ b/himbaechel/uarch/gowin/gowin.cc @@ -44,9 +44,9 @@ struct GowinImpl : HimbaechelAPI bool checkPipAvail(PipId pip) const override; // Cluster - bool isClusterStrict(const CellInfo *cell) const { return true; } + bool isClusterStrict(const CellInfo *cell) const override { return true; } bool getClusterPlacement(ClusterId cluster, BelId root_bel, - std::vector> &placement) const; + std::vector> &placement) const override; private: HimbaechelHelpers h; @@ -110,7 +110,7 @@ struct GowinArch : HimbaechelArch bool match_device(const std::string &device) override { return device.size() > 2 && device.substr(0, 2) == "GW"; } - std::unique_ptr create(const std::string &device, const dict &args) + std::unique_ptr create(const std::string &device, const dict &args) override { return std::make_unique(); } diff --git a/himbaechel/uarch/ng-ultra/ng_ultra.cc b/himbaechel/uarch/ng-ultra/ng_ultra.cc index f5932e71..109e8e73 100644 --- a/himbaechel/uarch/ng-ultra/ng_ultra.cc +++ b/himbaechel/uarch/ng-ultra/ng_ultra.cc @@ -1060,7 +1060,7 @@ struct NgUltraArch : HimbaechelArch { NgUltraArch() : HimbaechelArch("ng-ultra") {}; bool match_device(const std::string &device) override { return device == "NG-ULTRA"; } - std::unique_ptr create(const std::string &device, const dict &args) + std::unique_ptr create(const std::string &device, const dict &args) override { return std::make_unique(); } diff --git a/himbaechel/uarch/xilinx/xilinx.cc b/himbaechel/uarch/xilinx/xilinx.cc index 229c3e37..87b94d99 100644 --- a/himbaechel/uarch/xilinx/xilinx.cc +++ b/himbaechel/uarch/xilinx/xilinx.cc @@ -569,7 +569,7 @@ struct XilinxArch : HimbaechelArch { XilinxArch() : HimbaechelArch("xilinx") {}; bool match_device(const std::string &device) override { return device.size() > 3 && device.substr(0, 3) == "xc7"; } - std::unique_ptr create(const std::string &device, const dict &args) + std::unique_ptr create(const std::string &device, const dict &args) override { return std::make_unique(); }