From 32a4c5bd798241feb45f630267d95d635c967b4a Mon Sep 17 00:00:00 2001 From: Eddie Hung Date: Wed, 22 Aug 2018 09:24:30 -0700 Subject: [PATCH] Fix for min_slack == max_slack => bin_size == 0 --- common/timing.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/common/timing.cc b/common/timing.cc index 5e45f8a2..62697353 100644 --- a/common/timing.cc +++ b/common/timing.cc @@ -410,12 +410,13 @@ void timing_analysis(Context *ctx, bool print_histogram, bool print_path) log_info("estimated Fmax = %.2f MHz\n", 1e3 / ctx->getDelayNS(default_slack - min_slack)); if (print_histogram && slack_histogram.size() > 0) { - constexpr unsigned num_bins = 20; + unsigned num_bins = 20; unsigned bar_width = 60; auto min_slack = slack_histogram.begin()->first; auto max_slack = slack_histogram.rbegin()->first; - auto bin_size = (max_slack - min_slack) / num_bins; - std::vector bins(num_bins + 1); + auto bin_size = std::max(1u, (max_slack - min_slack) / num_bins); + num_bins = std::min((max_slack - min_slack) / bin_size, num_bins) + 1; + std::vector bins(num_bins); unsigned max_freq = 0; for (const auto &i : slack_histogram) { auto &bin = bins[(i.first - min_slack) / bin_size]; @@ -428,7 +429,7 @@ void timing_analysis(Context *ctx, bool print_histogram, bool print_path) log_info("Slack histogram:\n"); log_info(" legend: * represents %d endpoint(s)\n", max_freq / bar_width); log_info(" + represents [1,%d) endpoint(s)\n", max_freq / bar_width); - for (unsigned i = 0; i < bins.size(); ++i) + for (unsigned i = 0; i < num_bins; ++i) log_info("[%6d, %6d) |%s%c\n", min_slack + bin_size * i, min_slack + bin_size * (i + 1), std::string(bins[i] * bar_width / max_freq, '*').c_str(), (bins[i] * bar_width) % max_freq > 0 ? '+' : ' ');