caiyu/nextpnr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gui: treemodel: bail early on empty children updates in IdStringList

Browse Source
This commit is contained in:
Sergiusz Bazanski 2018-08-01 03:31:06 +01:00
parent f9d30bcdea
commit e423cceba8
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gui/treemodel.cc
View File

@ -56,6 +56,8 @@ std::vector<QString> IdStringList::alphaNumSplit(const QString &str)
void IdStringList::updateElements(Context *ctx, std::vector<IdString> elements) void IdStringList::updateElements(Context *ctx, std::vector<IdString> elements)
{ {
bool changed = false;
// For any elements that are not yet in managed_, created them. // For any elements that are not yet in managed_, created them.
std::unordered_set<IdString> element_set; std::unordered_set<IdString> element_set;
for (auto elem : elements) { for (auto elem : elements) {
@ -64,17 +66,29 @@ void IdStringList::updateElements(Context *ctx, std::vector<IdString> elements)
if (existing == managed_.end()) { if (existing == managed_.end()) {
auto item = new IdStringItem(ctx, elem, this, child_type_); auto item = new IdStringItem(ctx, elem, this, child_type_);
managed_.emplace(elem, std::unique_ptr<IdStringItem>(item)); managed_.emplace(elem, std::unique_ptr<IdStringItem>(item));
changed = true;
} }
} }
children_.clear();
// For any elements that are in managed_ but not in new, delete them. // For any elements that are in managed_ but not in new, delete them.
for (auto &pair : managed_) { for (auto &pair : managed_) {
if (element_set.count(pair.first) != 0) { if (element_set.count(pair.first) != 0) {
children_.push_back(pair.second.get());
continue; continue;
} }
managed_.erase(pair.first); managed_.erase(pair.first);
changed = true;
}
// Return early if there are no changes.
if (!changed)
return;
// Rebuild children list.
children_.clear();
for (auto &pair : managed_) {
if (element_set.count(pair.first) != 0) {
children_.push_back(pair.second.get());
}
} }
// Sort new children // Sort new children