From 022d012a4454952f454e33278af744c01f69667a Mon Sep 17 00:00:00 2001 From: EvilSpirit Date: Wed, 21 Dec 2016 22:56:53 +0700 Subject: [PATCH] Simplify Group::IsVisible(), GroupsInOrder(). --- src/generate.cpp | 11 ++--------- src/group.cpp | 3 ++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/generate.cpp b/src/generate.cpp index fc5769b..81795f8 100644 --- a/src/generate.cpp +++ b/src/generate.cpp @@ -57,15 +57,8 @@ bool SolveSpaceUI::PruneOrphans() { bool SolveSpaceUI::GroupsInOrder(hGroup before, hGroup after) { if(before.v == 0) return true; if(after.v == 0) return true; - - int beforep = -1, afterp = -1; - int i; - for(i = 0; i < SK.groupOrder.n; i++) { - hGroup hg = SK.groupOrder.elem[i]; - if(hg.v == before.v) beforep = i; - if(hg.v == after.v) afterp = i; - } - if(beforep < 0 || afterp < 0) return false; + int beforep = SK.GetGroup(before)->order; + int afterp = SK.GetGroup(after)->order; if(beforep >= afterp) return false; return true; } diff --git a/src/group.cpp b/src/group.cpp index 2a04d68..c3da08a 100644 --- a/src/group.cpp +++ b/src/group.cpp @@ -44,7 +44,8 @@ void Group::AddParam(IdList *param, hParam hp, double v) { bool Group::IsVisible() { if(!visible) return false; - if(SS.GroupsInOrder(SS.GW.activeGroup, h)) return false; + Group *active = SK.GetGroup(SS.GW.activeGroup); + if(order > active->order) return false; return true; }