caiyu/solvespace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not re-solve groups that converge but fail rank test.

Browse Source 
This partially reverts commit 3a585ea.

We no longer need this because the VectorsParallel() is gone, and
there is no chance of pivoting wrong when solving.
This commit is contained in:
whitequark 2016-11-27 14:24:20 +00:00
parent f5485cbf24
commit 7758844f96
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/generate.cpp
View File

@ -489,14 +489,8 @@ void SolveSpaceUI::SolveGroupAndReport(hGroup hg, bool andFindFree) {
SolveGroup(hg, andFindFree); SolveGroup(hg, andFindFree);
Group *g = SK.GetGroup(hg); Group *g = SK.GetGroup(hg);
if(g->solved.how == SolveResult::REDUNDANT_OKAY) {
// Solve again, in case we lost a degree of freedom because of a numeric error.
SolveGroup(hg, andFindFree);
}
bool isOkay = g->solved.how == SolveResult::OKAY || bool isOkay = g->solved.how == SolveResult::OKAY ||
(g->allowRedundant && g->solved.how == SolveResult::REDUNDANT_OKAY); (g->allowRedundant && g->solved.how == SolveResult::REDUNDANT_OKAY);
if(!isOkay || (isOkay && !g->IsSolvedOkay())) { if(!isOkay || (isOkay && !g->IsSolvedOkay())) {
TextWindow::ReportHowGroupSolved(g->h); TextWindow::ReportHowGroupSolved(g->h);
} }