From b9d035c805125c8116168aa76eae6b7f4765cd1d Mon Sep 17 00:00:00 2001 From: Ryan Pavlik Date: Thu, 23 May 2019 12:27:48 -0500 Subject: [PATCH] Improve MoveSelfInto. NFC. std::swap is an idiomatic way to do a move. --- src/dsc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/dsc.h b/src/dsc.h index 51d6f54..4accb1f 100644 --- a/src/dsc.h +++ b/src/dsc.h @@ -514,9 +514,9 @@ public: void MoveSelfInto(IdList *l) { l->Clear(); - *l = *this; - elemsAllocated = n = 0; - elem = NULL; + std::swap(l->elem, elem); + std::swap(l->elemsAllocated, elemsAllocated); + std::swap(l->n, n); } void DeepCopyInto(IdList *l) {