From bb5994ed7080d30f89286cfeb8abfb3fcb0e6721 Mon Sep 17 00:00:00 2001 From: ruevs Date: Mon, 23 Nov 2020 15:15:37 +0200 Subject: [PATCH] UI: Display "err" in the property browser only if "check sketch for closed contour" ... is enabled. "err" was first introduced in c2c26e95adb to indicate sketches that may cause problems in the subsequent 3D groups. But is makes sense not to display the error if the "check sketch for closed contour" option is turned off. The user obviously does not want to be warned. Based on a suggestion in https://github.com/solvespace/solvespace/issues/819 --- src/textscreens.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/textscreens.cpp b/src/textscreens.cpp index aac2703..07d5cde 100644 --- a/src/textscreens.cpp +++ b/src/textscreens.cpp @@ -143,7 +143,7 @@ void TextWindow::ShowListOfGroups() { // Link to the errors, if a problem occurred while solving ok ? (warn ? 'm' : (dof > 0 ? 'i' : 's')) : 'x', g->h.v, (&TextWindow::ScreenHowGroupSolved), - ok ? (warn ? "err" : sdof) : "", + ok ? ((warn && SS.checkClosedContour) ? "err" : sdof) : "", ok ? "" : "ERR", // Link to a screen that gives more details on the group g->h.v, (&TextWindow::ScreenSelectGroup), s.c_str());