Previously, when setting startFill/endFill, the display was inverted
comparing to the configuration.
The marker was filled when set to false, not filled when set to true.
When not set, the marker was filled, which is the expected default.
The issue came from a wrong condition to manage the default value and
was reproduced with the Markers Story.
In addition to the code fix, update the Markers.stories.js to fix style
configurations
- use number instead of string for markers size
- use boolean instead of number for start/end fill
`StyleSheet.getCellStyle` didn't keep the properties of the default
style when `baseStyleNames` was set in the `cellStyle` parameter.
The JSDoc was incorrect (it came from mxGraph) about how the style is
computed, in particular about the default style. It probably leads to
the erroneous implementation during migration. It is now fixed and
clearly describe the rules followed to merge style properties.
The 'Stylesheet' story has been updated to correctly use the maxGraph
API. It also includes more examples involving `baseStyleNames` to
show the 'properties merge' in action.
The `align` and `verticalAlign` values passed to the constructor weren't
set, so the overlay position was always set to
the default one.
The `align` and `verticalAlign` properties are now using the AlignValue
and VAlignValue types respectively instead of
defining inline types. This improves the consistent in the whole code.
To demonstrate the fix, the Overlays story now set 'align' and
'verticalAlign' randomly.
Also introduce `jest` to test the fix and the whole
implementation of the changed method. Types check support is provided by
`ts-jest`. As maxGraph uses a lot of browser objects, also setup
`jest-jsdom-environment`.
Root and all package.json files
- Fix license, version and authors
- Remove the non-relevant .npmignore file at the project. It was designed for mxgraph, the whole directory structure
changed, and we don't plan to publish the root package
`core` package
- Generate type definition and javascript files for ESM output
- dedicated folder for `esm` and `types` in the `dist` folder to clearly separate concerns
- exported in the package.json
- Add npm script for `npm pack` configuration
- Drop the `postinstall` npm script that built the `core` bundle. It would have been run when the package is installed
in dependent projects at dependencies install. And it would have failed as it tries to build the project from TypeScript
sources that are not available in the npm package.
fix: ConstraintHandler now loads image as everywhere else in the code using `Client.imageBasePath`
Using import doesn't work as the image is not available in the npm package. It generated error like this in ViteJS
project:
Failed to resolve import "../../../images/point.gif" from "../core/dist/esm/view/handler/ConstraintHandler.js". Does the file exist?
This gif import had been introduced to make `Anchors.stories.js` retrieve the gif file. Configuring `imageBasePath` as
already done in other stories fixes the issue.
Don't export EditorCodec and StylesheetCodec as they generate errors.
This is a temporary solution to avoid error in dependent project (at least, with ViteJS projects).
* reorganised directories; removed mx prefix
* reduced directory hierarchies; removed mx prefix; type fixes
* convert remaining javascript to ts
* fix/add types
* add type defs
* type updates; moved codecs to where they're used
* reorganise constants into enums+type additions
* removed "Function:" and "Variable:" prefixes from comments, as they aren't needed in JSDoc
* removed "Function:", "Variable:" and "Class:" prefixes from comments, as they aren't needed in JSDoc
* removed "Function:" prefixes from comments, as they aren't needed in JSDoc
* minor changes
* convert code example blocks to markdown
* module casing updates
* converted parameter function documentation to JSDoc
* documentation+type updates
* removed react subdir (for now)
* reorganised various `utils` functions into different files
* type updates/bugfixes/workarounds
* rename Rubberband and CellEditor to be *Handler to match the other plugins
* move codec classes to where they're used to reduce cyclic dependencies
* move codec classes to where they're used to reduce cyclic dependencies
* type updates/reorganize layout file structure
* renamed various files for consistency
* import fixes
* renamed GraphHandler SelectionHander and various fixes
* convert EventObject parameters to objects
* add basic better-docs config
* update better-docs config
* bugfix for shared variables in Graph persisting across instances
* fixed accessing handlers in examples; renamed Model to GraphModel
* fixed accessing handlers in examples; renamed Model to GraphModel
* restored selection model
* bugfix
* renamed getModel to getDataModel
* changed to use graph.batchUpdate() to reduce lines of code
* changed to use graph.batchUpdate() to reduce lines of code
* finished annotations+added TypeDoc
* convert remaining Cell[] instances to CellArray
* convert NaturalDocs links to JSDoc
Thomas Bouffard
Filip Wróbel
Анатолий Майоров
Junsik Shim
Dave Morrissey