zcy
/
openEMS
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MPI: critital fix in current update/transfer 

The normal current component at the upper boundaries are not updated
by the conventional engine as is needed for the interface interaction.

Workaround: transfer all three current components --> larger data transfer
Todo: needs to be properly fixed in the future!

Signed-off-by: Thorsten Liebig <Thorsten.Liebig@gmx.de>
pull/1/head
Thorsten Liebig 2011-02-21 09:53:32 +01:00
parent 9d51971c26
commit 23df0f63a0
2 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
FDTD/engine_mpi.cpp
View File

@ -49,17 +49,16 @@ void Engine_MPI::Init()
if (m_Op_MPI->GetMPIEnabled()) if (m_Op_MPI->GetMPIEnabled())
{ {
// init buffers, nx*ny*2 for the tangential electric or magnetic fields at the interface // init buffers, nx*ny*2 for the tangential electric or magnetic fields at the interface
m_BufferSize[2] = m_Op_MPI->numLines[0]*m_Op_MPI->numLines[1]*2; m_BufferSize[2] = m_Op_MPI->numLines[0]*m_Op_MPI->numLines[1];
if (m_Op_MPI->m_NeighborDown[2]>=0) if (m_Op_MPI->m_NeighborDown[2]>=0)
{ {
m_BufferDown[2] = new float[m_BufferSize[2]]; m_BufferDown[2] = new float[m_BufferSize[2]*3];
} }
if (m_Op_MPI->m_NeighborUp[2]>=0) if (m_Op_MPI->m_NeighborUp[2]>=0)
{ {
m_BufferUp[2] = new float[m_BufferSize[2]]; m_BufferUp[2] = new float[m_BufferSize[2]*3];
} }
} }
} }
void Engine_MPI::Reset() void Engine_MPI::Reset()
@ -86,7 +85,7 @@ void Engine_MPI::SendReceiveVoltages()
//non-blocking prepare for receive... //non-blocking prepare for receive...
for (int n=0;n<3;++n) for (int n=0;n<3;++n)
if (m_Op_MPI->m_NeighborDown[n]>=0) if (m_Op_MPI->m_NeighborDown[n]>=0)
MPI_Irecv( m_BufferDown[n] , m_BufferSize[n], MPI_FLOAT, m_Op_MPI->m_NeighborDown[n], m_Op_MPI->m_MyTag, MPI_COMM_WORLD, &Recv_Request[n]); MPI_Irecv( m_BufferDown[n] , m_BufferSize[n]*2, MPI_FLOAT, m_Op_MPI->m_NeighborDown[n], m_Op_MPI->m_MyTag, MPI_COMM_WORLD, &Recv_Request[n]);
for (int n=0;n<3;++n) for (int n=0;n<3;++n)
{ {
@ -106,7 +105,7 @@ void Engine_MPI::SendReceiveVoltages()
m_BufferUp[n][iPos++] = Engine_SSE_Compressed::GetVolt(nPP,pos); m_BufferUp[n][iPos++] = Engine_SSE_Compressed::GetVolt(nPP,pos);
} }
} }
MPI_Isend( m_BufferUp[n] , m_BufferSize[n], MPI_FLOAT, m_Op_MPI->m_NeighborUp[n], m_Op_MPI->m_MyTag, MPI_COMM_WORLD, &Send_Request[n]); MPI_Isend( m_BufferUp[n] , m_BufferSize[n]*2, MPI_FLOAT, m_Op_MPI->m_NeighborUp[n], m_Op_MPI->m_MyTag, MPI_COMM_WORLD, &Send_Request[n]);
} }
//receive voltages //receive voltages
@ -131,6 +130,14 @@ void Engine_MPI::SendReceiveVoltages()
void Engine_MPI::SendReceiveCurrents() void Engine_MPI::SendReceiveCurrents()
{ {
/*
TODO:
the FDTD engine could update the normal currents (e.g. i_z at z_max) (magnetic fields) on the last line, but the default engine does not need to...
workaround: transfer all three current components
drawback: data transfer is larger than necessary
future fix: update normal currents
*/
if (!m_Op_MPI->GetMPIEnabled()) if (!m_Op_MPI->GetMPIEnabled())
return; return;
@ -139,7 +146,7 @@ void Engine_MPI::SendReceiveCurrents()
//non-blocking prepare for receive... //non-blocking prepare for receive...
for (int n=0;n<3;++n) for (int n=0;n<3;++n)
if (m_Op_MPI->m_NeighborUp[n]>=0) if (m_Op_MPI->m_NeighborUp[n]>=0)
MPI_Irecv( m_BufferUp[n] , m_BufferSize[n], MPI_FLOAT, m_Op_MPI->m_NeighborUp[n], m_Op_MPI->m_MyTag, MPI_COMM_WORLD, &Recv_Request[n]); MPI_Irecv( m_BufferUp[n] , m_BufferSize[n]*3, MPI_FLOAT, m_Op_MPI->m_NeighborUp[n], m_Op_MPI->m_MyTag, MPI_COMM_WORLD, &Recv_Request[n]);
for (int n=0;n<3;++n) for (int n=0;n<3;++n)
{ {
@ -155,11 +162,12 @@ void Engine_MPI::SendReceiveCurrents()
{ {
for (pos[nPP]=0; pos[nPP]<numLines[nPP]; ++pos[nPP]) for (pos[nPP]=0; pos[nPP]<numLines[nPP]; ++pos[nPP])
{ {
m_BufferDown[n][iPos++] = Engine_SSE_Compressed::GetCurr(n ,pos);
m_BufferDown[n][iPos++] = Engine_SSE_Compressed::GetCurr(nP ,pos); m_BufferDown[n][iPos++] = Engine_SSE_Compressed::GetCurr(nP ,pos);
m_BufferDown[n][iPos++] = Engine_SSE_Compressed::GetCurr(nPP,pos); m_BufferDown[n][iPos++] = Engine_SSE_Compressed::GetCurr(nPP,pos);
} }
} }
MPI_Isend( m_BufferDown[n] , m_BufferSize[n], MPI_FLOAT, m_Op_MPI->m_NeighborDown[n], m_Op_MPI->m_MyTag, MPI_COMM_WORLD, &Send_Request[n]); MPI_Isend( m_BufferDown[n] , m_BufferSize[n]*3, MPI_FLOAT, m_Op_MPI->m_NeighborDown[n], m_Op_MPI->m_MyTag, MPI_COMM_WORLD, &Send_Request[n]);
} }
//receive currents //receive currents
@ -173,6 +181,7 @@ void Engine_MPI::SendReceiveCurrents()
{ {
for (pos[nPP]=0; pos[nPP]<numLines[nPP]; ++pos[nPP]) for (pos[nPP]=0; pos[nPP]<numLines[nPP]; ++pos[nPP])
{ {
Engine_SSE_Compressed::SetCurr(n ,pos,m_BufferUp[n][iPos++]);
Engine_SSE_Compressed::SetCurr(nP ,pos,m_BufferUp[n][iPos++]); Engine_SSE_Compressed::SetCurr(nP ,pos,m_BufferUp[n][iPos++]);
Engine_SSE_Compressed::SetCurr(nPP,pos,m_BufferUp[n][iPos++]); Engine_SSE_Compressed::SetCurr(nPP,pos,m_BufferUp[n][iPos++]);
} }

2
FDTD/engine_mpi.h
View File

@ -48,7 +48,9 @@ protected:
float* m_BufferUp[3]; float* m_BufferUp[3];
float* m_BufferDown[3]; float* m_BufferDown[3];
//! Transfer all tangential voltages at the upper bounds to the lower bounds of the neighbouring MPI-processes
void SendReceiveVoltages(); void SendReceiveVoltages();
//! Transfer all tangential currents at the lower bounds to the upper bounds of the neighbouring MPI-processes
void SendReceiveCurrents(); void SendReceiveCurrents();
}; };