zcy
/
pluto_hdl_adi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

avl_dacfifo: Fix dac_xfer_req generation 

The dac_xfer_req should indicate one single thing, that the FIFO is in
read phase. Should not be affected by any signals, which indicates data
validity on any interface. (e.g. dac_valid)
This signal is not used by the device core, its main purpose is to
indicate the state of the interface for a posible intermediat processing
module.
main
Istvan Csomortani 2017-11-03 09:32:10 +00:00
parent 572cd10c35
commit 960883c789
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
library/altera/avl_dacfifo/avl_dacfifo_rd.v
View File

@ -48,7 +48,7 @@ module avl_dacfifo_rd #(
input dac_reset, input dac_reset,
input dac_valid, input dac_valid,
output reg [(DAC_DATA_WIDTH-1):0] dac_data, output reg [(DAC_DATA_WIDTH-1):0] dac_data,
output reg dac_xfer_req, output dac_xfer_req,
output reg dac_dunf, output reg dac_dunf,
input avl_clk, input avl_clk,
@ -133,7 +133,6 @@ module avl_dacfifo_rd #(
reg [DAC_MEM_ADDRESS_WIDTH-1:0] dac_mem_laddr_b; reg [DAC_MEM_ADDRESS_WIDTH-1:0] dac_mem_laddr_b;
reg dac_mem_renable; reg dac_mem_renable;
reg dac_mem_valid; reg dac_mem_valid;
reg dac_xfer_req_b;
// internal signals // internal signals
@ -155,7 +154,6 @@ module avl_dacfifo_rd #(
wire dac_mem_laddr_rea_s; wire dac_mem_laddr_rea_s;
wire [DAC_MEM_ADDRESS_WIDTH-1:0] dac_mem_laddr_s; wire [DAC_MEM_ADDRESS_WIDTH-1:0] dac_mem_laddr_s;
wire dac_mem_dunf_s; wire dac_mem_dunf_s;
wire dac_xfer_req_s;
// An asymmetric memory to transfer data from Avalon interface to DAC // An asymmetric memory to transfer data from Avalon interface to DAC
// interface // interface
@ -451,17 +449,13 @@ module avl_dacfifo_rd #(
.din (dac_mem_waddr_m2), .din (dac_mem_waddr_m2),
.dout (dac_mem_waddr_g2b_s)); .dout (dac_mem_waddr_g2b_s));
assign dac_xfer_req_s = dac_avl_xfer_req & dac_mem_valid; assign dac_xfer_req = dac_mem_renable;
always @(posedge dac_clk) begin always @(posedge dac_clk) begin
if (dac_reset == 1'b1) begin if (dac_reset == 1'b1) begin
dac_avl_xfer_req_m2 <= 0; dac_avl_xfer_req_m2 <= 0;
dac_avl_xfer_req_m1 <= 0; dac_avl_xfer_req_m1 <= 0;
dac_avl_xfer_req <= 0; dac_avl_xfer_req <= 0;
dac_xfer_req_b <= 1'b0;
dac_xfer_req <= 1'b0;
end else begin end else begin
dac_xfer_req_b <= dac_xfer_req_s;
dac_xfer_req <= dac_xfer_req_b;
dac_avl_xfer_req_m1 <= avl_xfer_req_out; dac_avl_xfer_req_m1 <= avl_xfer_req_out;
dac_avl_xfer_req_m2 <= dac_avl_xfer_req_m1; dac_avl_xfer_req_m2 <= dac_avl_xfer_req_m1;
dac_avl_xfer_req <= dac_avl_xfer_req_m2; dac_avl_xfer_req <= dac_avl_xfer_req_m2;