zcy
/
pluto_hdl_adi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

axi_adc_trigger: Fix trigger out glitches 

Currently trigger out pin is hold for 1ms in the next translation(t+1)
state(0 or 1). But not in the state that follows (t+2). This commit
fixes this issue and simplifies the logic.
main
AndreiGrozav 2019-08-23 17:38:27 +03:00 committed by AndreiGrozav
parent 97dfb938b6
commit a69863609b
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
library/axi_adc_trigger/axi_adc_trigger.v
View File

@ -39,7 +39,8 @@ module axi_adc_trigger #(
// parameters // parameters
parameter SIGN_BITS = 2) ( parameter SIGN_BITS = 2,
parameter OUT_PIN_HOLD_N = 100000) (
// interface // interface
@ -171,13 +172,12 @@ module axi_adc_trigger #(
reg trigger_pin_a; reg trigger_pin_a;
reg trigger_pin_b; reg trigger_pin_b;
reg [ 1:0] trigger_o_m; reg [ 1:0] trigger_o_m = 1'd0;
reg [ 1:0] trigger_o_m_1;
reg trig_o_hold_0; reg trig_o_hold_0 = 1'b0;
reg trig_o_hold_1; reg trig_o_hold_1 = 1'b0;
reg [16:0] trig_o_hold_cnt_0; reg [16:0] trig_o_hold_cnt_0 = 17'd0;
reg [16:0] trig_o_hold_cnt_1; reg [16:0] trig_o_hold_cnt_1 = 17'd0;
reg trigger_adc_a; reg trigger_adc_a;
reg trigger_adc_b; reg trigger_adc_b;
@ -247,26 +247,23 @@ module axi_adc_trigger #(
// trigger out is acknowledged by the hold counter will be disregarded for 1ms. // trigger out is acknowledged by the hold counter will be disregarded for 1ms.
// This was done to avoid noise created by high frequency switches on long // This was done to avoid noise created by high frequency switches on long
// wires. // wires.
always @(posedge clk) begin always @(posedge clk) begin
// trigger_o[0] hold start // trigger_o[0] hold start
if ((trigger_o_m[0] != trigger_o_m_1[0]) & (trig_o_hold_cnt_0 == 17'd0)) begin
trig_o_hold_cnt_0 <= 17'd100000;
trig_o_hold_0 <= trigger_o_m[0];
end
if (trig_o_hold_cnt_0 != 17'd0) begin if (trig_o_hold_cnt_0 != 17'd0) begin
trig_o_hold_cnt_0 <= trig_o_hold_cnt_0 - 17'd1; trig_o_hold_cnt_0 <= trig_o_hold_cnt_0 - 17'd1;
end else if (trig_o_hold_0 != trigger_o_m[0]) begin
trig_o_hold_cnt_0 <= OUT_PIN_HOLD_N;
trig_o_hold_0 <= trigger_o_m[0];
end end
trigger_o_m_1[0] <= trigger_o_m[0];
// trigger_o[1] hold start // trigger_o[1] hold start
if ((trigger_o_m[1] != trigger_o_m_1[1]) & (trig_o_hold_cnt_1 == 17'd0)) begin
trig_o_hold_cnt_1 <= 17'd100000;
trig_o_hold_1 <= trigger_o_m[1];
end
if (trig_o_hold_cnt_1 != 17'd0) begin if (trig_o_hold_cnt_1 != 17'd0) begin
trig_o_hold_cnt_1 <= trig_o_hold_cnt_1 - 17'd1; trig_o_hold_cnt_1 <= trig_o_hold_cnt_1 - 17'd1;
end else if (trig_o_hold_1 != trigger_o_m[1]) begin
trig_o_hold_cnt_1 <= OUT_PIN_HOLD_N;
trig_o_hold_1 <= trigger_o_m[1];
end end
trigger_o_m_1[1] <= trigger_o_m[1];
// hold // hold
trigger_o[0] <= (trig_o_hold_cnt_0 == 'd0) ? trigger_o_m[0] : trig_o_hold_0; trigger_o[0] <= (trig_o_hold_cnt_0 == 'd0) ? trigger_o_m[0] : trig_o_hold_0;