zcy
/
solvespace
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Three.js: update inaccurate comment. NFC.

pull/409/head
William D. Jones 2017-08-25 19:16:30 -04:00 committed by whitequark
parent b97a80b6ed
commit 201e15e68a
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
res/threejs/SolveSpaceControls.js
View File

@ -25,10 +25,11 @@ SolvespaceCamera.prototype.updateProjectionMatrix = function() {
var n = new THREE.Vector3().crossVectors(this.up, this.right);
var rotate = new THREE.Matrix4().makeBasis(this.right, this.up, n);
rotate.transpose();
/* FIXME: At some point we ended up using row-major.
THREE.js wants column major. Scale/depth correct unaffected b/c diagonal
matrices remain the same when transposed. makeTranslation also makes
a column-major matrix. */
/* Transpose of rotation matrix == inverse. Rotating the camera by a
basis is equivalent to rotating an object by the inverse of the
basis. To mimic Solvespace's behavior, we pan relative to the camera.
So we need to be rotated to where the camera is pointing before panning.
See: https://en.wikipedia.org/wiki/Change_of_basis#Two_dimensions */
/* TODO: If we want perspective, we need an additional matrix
here which will modify w for perspective divide. */