zcy
/
solvespace
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix use-after-free in Lathe, Revolve, and Helix. Issue #611.

pull/613/head
phkahler 2020-05-12 15:09:36 -04:00
parent 0be42a8b29
commit 23dfd97285
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/group.cpp
View File

@ -533,6 +533,7 @@ void Group::Generate(IdList<Entity,hEntity> *entity,
NO_PARAM, NO_PARAM, NO_PARAM, NO_PARAM, NO_PARAM, NO_PARAM, NO_PARAM, NO_PARAM, NO_PARAM, NO_PARAM,
CopyAs::NUMERIC); CopyAs::NUMERIC);
e = &(entity->Get(i)); // because we copied.
if (e->IsPoint()) { if (e->IsPoint()) {
// for points this copy is used for the circle centers // for points this copy is used for the circle centers
CopyEntity(entity, SK.GetEntity(he), 0, REMAP_LATHE_ARC_CENTER, CopyEntity(entity, SK.GetEntity(he), 0, REMAP_LATHE_ARC_CENTER,
@ -586,6 +587,7 @@ void Group::Generate(IdList<Entity,hEntity> *entity,
h.param(1), h.param(2), h.param(3), h.param(4), h.param(5), h.param(1), h.param(2), h.param(3), h.param(4), h.param(5),
h.param(6), NO_PARAM, CopyAs::N_ROT_AA); h.param(6), NO_PARAM, CopyAs::N_ROT_AA);
e = &(entity->Get(i)); // because we copied.
CopyEntity(entity, e, af, REMAP_LATHE_END, h.param(0), CopyEntity(entity, e, af, REMAP_LATHE_END, h.param(0),
h.param(1), h.param(2), h.param(3), h.param(4), h.param(5), h.param(1), h.param(2), h.param(3), h.param(4), h.param(5),
h.param(6), NO_PARAM, CopyAs::N_ROT_AA); h.param(6), NO_PARAM, CopyAs::N_ROT_AA);
@ -641,6 +643,7 @@ void Group::Generate(IdList<Entity,hEntity> *entity,
h.param(1), h.param(2), h.param(3), h.param(4), h.param(5), h.param(1), h.param(2), h.param(3), h.param(4), h.param(5),
h.param(6), h.param(7), CopyAs::N_ROT_AXIS_TRANS); h.param(6), h.param(7), CopyAs::N_ROT_AXIS_TRANS);
e = &(entity->Get(i)); // because we copied.
CopyEntity(entity, e, af, REMAP_LATHE_END, h.param(0), CopyEntity(entity, e, af, REMAP_LATHE_END, h.param(0),
h.param(1), h.param(2), h.param(3), h.param(4), h.param(5), h.param(1), h.param(2), h.param(3), h.param(4), h.param(5),
h.param(6), h.param(7), CopyAs::N_ROT_AXIS_TRANS); h.param(6), h.param(7), CopyAs::N_ROT_AXIS_TRANS);