Do not re-solve groups that converge but fail rank test.
This partially reverts commit 3a585ea
.
We no longer need this because the VectorsParallel() is gone, and
there is no chance of pivoting wrong when solving.
pull/36/merge
parent
f5485cbf24
commit
7758844f96
|
@ -489,14 +489,8 @@ void SolveSpaceUI::SolveGroupAndReport(hGroup hg, bool andFindFree) {
|
|||
SolveGroup(hg, andFindFree);
|
||||
|
||||
Group *g = SK.GetGroup(hg);
|
||||
if(g->solved.how == SolveResult::REDUNDANT_OKAY) {
|
||||
// Solve again, in case we lost a degree of freedom because of a numeric error.
|
||||
SolveGroup(hg, andFindFree);
|
||||
}
|
||||
|
||||
bool isOkay = g->solved.how == SolveResult::OKAY ||
|
||||
(g->allowRedundant && g->solved.how == SolveResult::REDUNDANT_OKAY);
|
||||
|
||||
if(!isOkay || (isOkay && !g->IsSolvedOkay())) {
|
||||
TextWindow::ReportHowGroupSolved(g->h);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue