f33ddc94fb
Specifically, take the old code that looks like this:
class Foo {
enum { X = 1, Y = 2 };
int kind;
}
... foo.kind = Foo::X; ...
and convert it to this:
class Foo {
enum class Kind : uint32_t { X = 1, Y = 2 };
Kind kind;
}
... foo.kind = Foo::Kind::X;
(In some cases the enumeration would not be in the class namespace,
such as when it is generally useful.)
The benefits are as follows:
* The type of the field gives a clear indication of intent, both
to humans and tools (such as binding generators).
* The compiler is able to automatically warn when a switch is not
exhaustive; but this is currently suppressed by the
default: ssassert(false, ...)
idiom.
* Integers and plain enums are weakly type checked: they implicitly
convert into each other. This can hide bugs where type conversion
is performed but not intended. Enum classes are strongly type
checked.
* Plain enums pollute parent namespaces; enum classes do not.
Almost every defined enum we have already has a kind of ad-hoc
namespacing via `NAMESPACE_`, which is now explicit.
* Plain enums do not have a well-defined ABI size, which is
important for bindings. Enum classes can have it, if specified.
We specify the base type for all enums as uint32_t, which is
a safe choice and allows us to not change the numeric values
of any variants.
This commit introduces absolutely no functional change to the code,
just renaming and change of types. It handles almost all cases,
except GraphicsWindow::pending.operation, which needs minor
functional change.
|
||
|---|---|---|
| .travis | ||
| cmake | ||
| debian | ||
| exposed | ||
| extlib | ||
| include | ||
| res | ||
| src | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .travis.yml | ||
| CMakeLists.txt | ||
| COPYING.txt | ||
| README.md | ||
| appveyor.yml | ||
| wishlist.txt | ||
README.md
SolveSpace
This repository contains the source code of SolveSpace, a parametric 2d/3d CAD.
Installation
Mac OS X (>=10.6 64-bit), Debian (>=jessie) and Ubuntu (>=trusty)
Binary packages for Mac OS X and Debian derivatives are available via GitHub releases.
Other systems
See below.
Building on Linux
Building for Linux
You will need CMake, libpng, zlib, json-c, fontconfig, freetype, gtkmm 2.4, pangomm 1.4, OpenGL and OpenGL GLU. On a Debian derivative (e.g. Ubuntu) these can be installed with:
apt-get install libpng12-dev libjson-c-dev libfreetype6-dev \
libfontconfig1-dev libgtkmm-2.4-dev libpangomm-1.4-dev \
libgl-dev libglu-dev libglew-dev cmake
Before building, check out the necessary submodules:
git submodule update --init extlib/libdxfrw
After that, build SolveSpace as following:
mkdir build
cd build
cmake ..
make
sudo make install
A fully functional port to GTK3 is available, but not recommended for use due to bugs in this toolkit.
Building for Windows
You will need CMake, a Windows cross-compiler, and Wine with binfmt support. On a Debian derivative (e.g. Ubuntu) these can be installed with:
apt-get install cmake mingw-w64 wine-binfmt
Before building, check out the necessary submodules:
git submodule update --init
After that, build 32-bit SolveSpace as following:
mkdir build
cd build
cmake -DCMAKE_TOOLCHAIN_FILE=../cmake/Toolchain-mingw32.cmake ..
make solvespace
Or, build 64-bit SolveSpace as following:
mkdir build
cd build
cmake -DCMAKE_TOOLCHAIN_FILE=../cmake/Toolchain-mingw64.cmake ..
make solvespace
The application is built as build/src/solvespace.exe.
Space Navigator support will not be available.
Building on Mac OS X
You will need XCode tools, CMake, libpng and Freetype. Assuming you use homebrew, these can be installed with:
brew install cmake libpng freetype
XCode has to be installed via AppStore; it requires a free Apple ID.
Before building, check out the necessary submodules:
git submodule update --init extlib/libdxfrw
After that, build SolveSpace as following:
mkdir build
cd build
cmake ..
make
The app bundle is built in build/src/solvespace.app.
Building on Windows
You will need cmake and Visual C++.
GUI build
Check out the git submodules. Create a directory build in
the source tree and point cmake-gui to the source tree and that directory.
Press "Configure" and "Generate", then open build\solvespace.sln with
Visual C++ and build it.
Command-line build
First, ensure that git and cl (the Visual C++ compiler driver) are in your
%PATH%; the latter is usually done by invoking vcvarsall.bat from your
Visual Studio install. Then, run the following in cmd or PowerShell:
git submodule update --init
mkdir build
cd build
cmake .. -G "NMake Makefiles"
nmake
MSVC build
It is also possible to build SolveSpace using MinGW, though Space Navigator support will be disabled.
First, ensure that git and gcc are in your $PATH. Then, run the following
in bash:
git submodule update --init
mkdir build
cd build
cmake ..
make
License
SolveSpace is distributed under the terms of the GPL3 license.