svgedit/cypress/e2e/unit/utilities-bbox.cy.js

514 lines
19 KiB
JavaScript
Raw Normal View History

import 'pathseg'
import { NS } from '../../../instrumented/svgcanvas/namespaces.js'
import * as utilities from '../../../instrumented/svgcanvas/utilities.js'
import * as math from '../../../instrumented/svgcanvas/math.js'
import * as path from '../../../instrumented/svgcanvas/path.js'
import setAssertionMethods from '../../support/assert-close.js'
// eslint-disable-next-line
chai.use(setAssertionMethods)
describe('utilities bbox', function () {
/**
* Create an SVG element for a mock.
* @param {module:utilities.SVGElementJSON} jsonMap
* @returns {SVGElement}
*/
function mockCreateSVGElement (jsonMap) {
const elem = document.createElementNS(NS.SVG, jsonMap.element)
Object.entries(jsonMap.attr).forEach(([attr, value]) => {
elem.setAttribute(attr, value)
})
return elem
}
2021-12-30 10:38:10 +00:00
let mockaddSVGElementsFromJsonCallCount = 0
/**
2021-12-30 10:38:10 +00:00
* Mock of {@link module:utilities.EditorContext#addSVGElementsFromJson}.
* @param {module:utilities.SVGElementJSON} json
* @returns {SVGElement}
*/
2021-12-30 10:38:10 +00:00
function mockaddSVGElementsFromJson (json) {
const elem = mockCreateSVGElement(json)
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
mockaddSVGElementsFromJsonCallCount++
return elem
}
const mockPathActions = {
resetOrientation (pth) {
if (pth?.nodeName !== 'path') { return false }
const tlist = pth.transform.baseVal
const m = math.transformListToTransform(tlist).matrix
tlist.clear()
pth.removeAttribute('transform')
const segList = pth.pathSegList
const len = segList.numberOfItems
// let lastX, lastY;
for (let i = 0; i < len; ++i) {
const seg = segList.getItem(i)
const type = seg.pathSegType
if (type === 1) { continue }
const pts = [];
['', 1, 2].forEach(function (n) {
const x = seg['x' + n]; const y = seg['y' + n]
if (x !== undefined && y !== undefined) {
const pt = math.transformPoint(x, y, m)
pts.splice(pts.length, 0, pt.x, pt.y)
}
})
path.replacePathSeg(type, i, pts, pth)
}
return undefined
}
}
const EPSILON = 0.001
let svgroot
beforeEach(() => {
document.body.textContent = ''
// const svg = document.createElementNS(NS.SVG, 'svg');
const sandbox = document.createElement('div')
sandbox.id = 'sandbox'
document.body.append(sandbox)
svgroot = mockCreateSVGElement({
element: 'svg',
2021-05-12 23:00:09 +00:00
attr: { id: 'svgroot' }
})
sandbox.append(svgroot)
2021-12-27 23:54:49 +00:00
const mockSvgCanvas = {
createSVGElement (jsonMap) {
const elem = document.createElementNS(NS.SVG, jsonMap.element)
Object.entries(jsonMap.attr).forEach(([attr, value]) => {
elem.setAttribute(attr, value)
})
return elem
2021-12-27 23:54:49 +00:00
},
getSvgRoot () { return svgroot }
}
2021-12-27 23:54:49 +00:00
path.init(mockSvgCanvas)
2021-12-30 10:38:10 +00:00
mockaddSVGElementsFromJsonCallCount = 0
})
it('Test svgedit.utilities package', function () {
assert.ok(utilities)
assert.ok(utilities.getBBoxWithTransform)
assert.ok(utilities.getStrokedBBox)
assert.ok(utilities.getRotationAngleFromTransformList)
assert.ok(utilities.getRotationAngle)
})
it('Test getBBoxWithTransform and no transform', function () {
const { getBBoxWithTransform } = utilities
let elem = mockCreateSVGElement({
element: 'path',
2021-05-12 23:00:09 +00:00
attr: { id: 'path', d: 'M0,1 L2,3' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
let bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 2, height: 2 })
2021-12-30 10:38:10 +00:00
assert.equal(mockaddSVGElementsFromJsonCallCount, 0)
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '0', y: '1', width: '5', height: '10' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 10 })
2021-12-30 10:38:10 +00:00
assert.equal(mockaddSVGElementsFromJsonCallCount, 0)
elem.remove()
elem = mockCreateSVGElement({
element: 'line',
2021-05-12 23:00:09 +00:00
attr: { id: 'line', x1: '0', y1: '1', x2: '5', y2: '6' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 5 })
2021-12-30 10:38:10 +00:00
assert.equal(mockaddSVGElementsFromJsonCallCount, 0)
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '0', y: '1', width: '5', height: '10' }
})
const g = mockCreateSVGElement({
element: 'g',
attr: {}
})
g.append(elem)
svgroot.append(g)
2021-12-30 10:38:10 +00:00
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 10 })
2021-12-30 10:38:10 +00:00
assert.equal(mockaddSVGElementsFromJsonCallCount, 0)
g.remove()
})
2021-05-30 22:10:26 +00:00
it('Test getBBoxWithTransform and a rotation transform', function () {
const { getBBoxWithTransform } = utilities
let elem = mockCreateSVGElement({
element: 'path',
2021-05-12 23:00:09 +00:00
attr: { id: 'path', d: 'M10,10 L20,20', transform: 'rotate(45 10,10)' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
let bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
assert.close(bbox.x, 10, EPSILON)
assert.close(bbox.y, 10, EPSILON)
assert.close(bbox.width, 0, EPSILON)
assert.close(bbox.height, Math.sqrt(100 + 100), EPSILON)
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '10', y: '10', width: '10', height: '20', transform: 'rotate(90 15,20)' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
assert.close(bbox.x, 5, EPSILON)
assert.close(bbox.y, 15, EPSILON)
assert.close(bbox.width, 20, EPSILON)
assert.close(bbox.height, 10, EPSILON)
2021-12-30 10:38:10 +00:00
assert.equal(mockaddSVGElementsFromJsonCallCount, 1)
elem.remove()
const rect = { x: 10, y: 10, width: 10, height: 20 }
const angle = 45
const origin = { x: 15, y: 20 }
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect2', x: rect.x, y: rect.y, width: rect.width, height: rect.height, transform: 'rotate(' + angle + ' ' + origin.x + ',' + origin.y + ')' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
mockaddSVGElementsFromJsonCallCount = 0
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
const r2 = rotateRect(rect, angle, origin)
assert.close(bbox.x, r2.x, EPSILON, 'rect2 x is ' + r2.x)
assert.close(bbox.y, r2.y, EPSILON, 'rect2 y is ' + r2.y)
assert.close(bbox.width, r2.width, EPSILON, 'rect2 width is' + r2.width)
assert.close(bbox.height, r2.height, EPSILON, 'rect2 height is ' + r2.height)
2021-12-30 10:38:10 +00:00
assert.equal(mockaddSVGElementsFromJsonCallCount, 0)
elem.remove()
// Same as previous but wrapped with g and the transform is with the g.
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect3', x: rect.x, y: rect.y, width: rect.width, height: rect.height }
})
const g = mockCreateSVGElement({
element: 'g',
2021-05-12 23:00:09 +00:00
attr: { transform: 'rotate(' + angle + ' ' + origin.x + ',' + origin.y + ')' }
})
g.append(elem)
svgroot.append(g)
2021-12-30 10:38:10 +00:00
mockaddSVGElementsFromJsonCallCount = 0
bbox = getBBoxWithTransform(g, mockaddSVGElementsFromJson, mockPathActions)
assert.close(bbox.x, r2.x, EPSILON, 'rect2 x is ' + r2.x)
assert.close(bbox.y, r2.y, EPSILON, 'rect2 y is ' + r2.y)
assert.close(bbox.width, r2.width, EPSILON, 'rect2 width is' + r2.width)
assert.close(bbox.height, r2.height, EPSILON, 'rect2 height is ' + r2.height)
2021-12-30 10:38:10 +00:00
assert.equal(mockaddSVGElementsFromJsonCallCount, 0)
g.remove()
elem = mockCreateSVGElement({
element: 'ellipse',
2021-05-12 23:00:09 +00:00
attr: { id: 'ellipse1', cx: '100', cy: '100', rx: '50', ry: '50', transform: 'rotate(45 100,100)' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
mockaddSVGElementsFromJsonCallCount = 0
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
2021-05-09 17:29:45 +00:00
/** @todo: Review these test the BBox algorithm is using the bezier control points to calculate the bounding box. Should be 50, 50, 100, 100. */
// assert.ok(bbox.x > 45 && bbox.x <= 50);
assert.ok(bbox.y > 45 && bbox.y <= 50)
2021-05-09 17:29:45 +00:00
// assert.ok(bbox.width >= 100 && bbox.width < 110);
// assert.ok(bbox.height >= 100 && bbox.height < 110);
2021-12-30 10:38:10 +00:00
assert.equal(mockaddSVGElementsFromJsonCallCount, 1)
elem.remove()
})
2021-05-30 22:10:26 +00:00
it('Test getBBoxWithTransform with rotation and matrix transforms', function () {
const { getBBoxWithTransform } = utilities
let tx = 10 // tx right
let ty = 10 // tx down
let txInRotatedSpace = Math.sqrt(tx * tx + ty * ty) // translate in rotated 45 space.
let tyInRotatedSpace = 0
let matrix = 'matrix(1,0,0,1,' + txInRotatedSpace + ',' + tyInRotatedSpace + ')'
let elem = mockCreateSVGElement({
element: 'path',
2021-05-12 23:00:09 +00:00
attr: { id: 'path', d: 'M10,10 L20,20', transform: 'rotate(45 10,10) ' + matrix }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
let bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
assert.close(bbox.x, 10 + tx, EPSILON)
assert.close(bbox.y, 10 + ty, EPSILON)
assert.close(bbox.width, 0, EPSILON)
assert.close(bbox.height, Math.sqrt(100 + 100), EPSILON)
elem.remove()
txInRotatedSpace = tx // translate in rotated 90 space.
tyInRotatedSpace = -ty
matrix = 'matrix(1,0,0,1,' + txInRotatedSpace + ',' + tyInRotatedSpace + ')'
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '10', y: '10', width: '10', height: '20', transform: 'rotate(90 15,20) ' + matrix }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
assert.close(bbox.x, 5 + tx, EPSILON)
assert.close(bbox.y, 15 + ty, EPSILON)
assert.close(bbox.width, 20, EPSILON)
assert.close(bbox.height, 10, EPSILON)
elem.remove()
const rect = { x: 10, y: 10, width: 10, height: 20 }
const angle = 45
const origin = { x: 15, y: 20 }
tx = 10 // tx right
ty = 10 // tx down
txInRotatedSpace = Math.sqrt(tx * tx + ty * ty) // translate in rotated 45 space.
tyInRotatedSpace = 0
matrix = 'matrix(1,0,0,1,' + txInRotatedSpace + ',' + tyInRotatedSpace + ')'
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect2', x: rect.x, y: rect.y, width: rect.width, height: rect.height, transform: 'rotate(' + angle + ' ' + origin.x + ',' + origin.y + ') ' + matrix }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
const r2 = rotateRect(rect, angle, origin)
assert.close(bbox.x, r2.x + tx, EPSILON, 'rect2 x is ' + r2.x)
assert.close(bbox.y, r2.y + ty, EPSILON, 'rect2 y is ' + r2.y)
assert.close(bbox.width, r2.width, EPSILON, 'rect2 width is' + r2.width)
assert.close(bbox.height, r2.height, EPSILON, 'rect2 height is ' + r2.height)
elem.remove()
// Same as previous but wrapped with g and the transform is with the g.
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect3', x: rect.x, y: rect.y, width: rect.width, height: rect.height }
})
const g = mockCreateSVGElement({
element: 'g',
2021-05-12 23:00:09 +00:00
attr: { transform: 'rotate(' + angle + ' ' + origin.x + ',' + origin.y + ') ' + matrix }
})
g.append(elem)
svgroot.append(g)
2021-12-30 10:38:10 +00:00
bbox = getBBoxWithTransform(g, mockaddSVGElementsFromJson, mockPathActions)
assert.close(bbox.x, r2.x + tx, EPSILON, 'rect2 x is ' + r2.x)
assert.close(bbox.y, r2.y + ty, EPSILON, 'rect2 y is ' + r2.y)
assert.close(bbox.width, r2.width, EPSILON, 'rect2 width is' + r2.width)
assert.close(bbox.height, r2.height, EPSILON, 'rect2 height is ' + r2.height)
g.remove()
elem = mockCreateSVGElement({
element: 'ellipse',
2021-05-12 23:00:09 +00:00
attr: { id: 'ellipse1', cx: '100', cy: '100', rx: '50', ry: '50', transform: 'rotate(45 100,100) ' + matrix }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getBBoxWithTransform(elem, mockaddSVGElementsFromJson, mockPathActions)
2021-05-09 17:29:45 +00:00
/** @todo: the BBox algorithm is using the bezier control points to calculate the bounding box. Should be 50, 50, 100, 100. */
// assert.ok(bbox.x > 45 + tx && bbox.x <= 50 + tx);
assert.ok(bbox.y > 45 + ty && bbox.y <= 50 + ty)
2021-05-09 17:29:45 +00:00
// assert.ok(bbox.width >= 100 && bbox.width < 110);
// assert.ok(bbox.height >= 100 && bbox.height < 110);
elem.remove()
})
it('Test getStrokedBBox with stroke-width 10', function () {
const { getStrokedBBox } = utilities
const strokeWidth = 10
let elem = mockCreateSVGElement({
element: 'path',
2021-05-12 23:00:09 +00:00
attr: { id: 'path', d: 'M0,1 L2,3', 'stroke-width': strokeWidth }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
let bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0 - strokeWidth / 2, y: 1 - strokeWidth / 2, width: 2 + strokeWidth, height: 2 + strokeWidth })
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '0', y: '1', width: '5', height: '10', 'stroke-width': strokeWidth }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0 - strokeWidth / 2, y: 1 - strokeWidth / 2, width: 5 + strokeWidth, height: 10 + strokeWidth })
elem.remove()
elem = mockCreateSVGElement({
element: 'line',
2021-05-12 23:00:09 +00:00
attr: { id: 'line', x1: '0', y1: '1', x2: '5', y2: '6', 'stroke-width': strokeWidth }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0 - strokeWidth / 2, y: 1 - strokeWidth / 2, width: 5 + strokeWidth, height: 5 + strokeWidth })
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '0', y: '1', width: '5', height: '10', 'stroke-width': strokeWidth }
})
const g = mockCreateSVGElement({
element: 'g',
attr: {}
})
g.append(elem)
svgroot.append(g)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0 - strokeWidth / 2, y: 1 - strokeWidth / 2, width: 5 + strokeWidth, height: 10 + strokeWidth })
g.remove()
})
it("Test getStrokedBBox with stroke-width 'none'", function () {
const { getStrokedBBox } = utilities
let elem = mockCreateSVGElement({
element: 'path',
2021-05-12 23:00:09 +00:00
attr: { id: 'path', d: 'M0,1 L2,3', 'stroke-width': 'none' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
let bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 2, height: 2 })
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '0', y: '1', width: '5', height: '10', 'stroke-width': 'none' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 10 })
elem.remove()
elem = mockCreateSVGElement({
element: 'line',
2021-05-12 23:00:09 +00:00
attr: { id: 'line', x1: '0', y1: '1', x2: '5', y2: '6', 'stroke-width': 'none' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 5 })
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '0', y: '1', width: '5', height: '10', 'stroke-width': 'none' }
})
const g = mockCreateSVGElement({
element: 'g',
attr: {}
})
g.append(elem)
svgroot.append(g)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 10 })
g.remove()
})
it('Test getStrokedBBox with no stroke-width attribute', function () {
const { getStrokedBBox } = utilities
let elem = mockCreateSVGElement({
element: 'path',
2021-05-12 23:00:09 +00:00
attr: { id: 'path', d: 'M0,1 L2,3' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
let bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 2, height: 2 })
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '0', y: '1', width: '5', height: '10' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 10 })
elem.remove()
elem = mockCreateSVGElement({
element: 'line',
2021-05-12 23:00:09 +00:00
attr: { id: 'line', x1: '0', y1: '1', x2: '5', y2: '6' }
})
svgroot.append(elem)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 5 })
elem.remove()
elem = mockCreateSVGElement({
element: 'rect',
2021-05-12 23:00:09 +00:00
attr: { id: 'rect', x: '0', y: '1', width: '5', height: '10' }
})
const g = mockCreateSVGElement({
element: 'g',
attr: {}
})
g.append(elem)
svgroot.append(g)
2021-12-30 10:38:10 +00:00
bbox = getStrokedBBox([elem], mockaddSVGElementsFromJson, mockPathActions)
assert.deepEqual(bbox, { x: 0, y: 1, width: 5, height: 10 })
g.remove()
})
/**
* Returns radians for degrees.
* @param {Float} degrees
* @returns {Float}
*/
function radians (degrees) {
return degrees * Math.PI / 180
}
/**
*
* @param {module:utilities.BBoxObject} point
* @param {Float} angle
* @param {module:math.XYObject} origin
* @returns {module:math.XYObject}
*/
2022-01-05 21:00:02 +00:00
function rotatePoint (point, angle, origin = { x: 0, y: 0 }) {
const x = point.x - origin.x
const y = point.y - origin.y
const theta = radians(angle)
return {
x: x * Math.cos(theta) + y * Math.sin(theta) + origin.x,
y: x * Math.sin(theta) + y * Math.cos(theta) + origin.y
}
}
/**
*
* @param {module:utilities.BBoxObject} rect
* @param {Float} angle
* @param {module:math.XYObject} origin
* @returns {module:utilities.BBoxObject}
*/
function rotateRect (rect, angle, origin) {
const tl = rotatePoint({ x: rect.x, y: rect.y }, angle, origin)
const tr = rotatePoint({ x: rect.x + rect.width, y: rect.y }, angle, origin)
const br = rotatePoint({ x: rect.x + rect.width, y: rect.y + rect.height }, angle, origin)
const bl = rotatePoint({ x: rect.x, y: rect.y + rect.height }, angle, origin)
const minx = Math.min(tl.x, tr.x, bl.x, br.x)
const maxx = Math.max(tl.x, tr.x, bl.x, br.x)
const miny = Math.min(tl.y, tr.y, bl.y, br.y)
const maxy = Math.max(tl.y, tr.y, bl.y, br.y)
return {
x: minx,
y: miny,
width: (maxx - minx),
height: (maxy - miny)
}
}
})