From 18bbfe8c1536f1da3957de1d07a892b00f03dc4c Mon Sep 17 00:00:00 2001 From: Brett Zamir Date: Fri, 16 Nov 2018 15:15:17 +0800 Subject: [PATCH] - Linting (ESLint): Avoid JSON quoting --- .eslintrc.js | 92 ++++++++++++++++++++++++++-------------------------- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index e5e73a9e..2558a110 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -1,57 +1,57 @@ module.exports = { - "extends": [ + extends: [ "ash-nazg/sauron-node", "plugin:qunit/recommended", "plugin:testcafe/recommended" ], - "parserOptions": { - "sourceType": "module" + parserOptions: { + sourceType: "module" }, // Need to make explicit here for processing by jsdoc/check-examples - "plugins": ["qunit"], - "env": { - "browser": true + plugins: ["qunit"], + env: { + browser: true }, - "settings": { - "polyfills": ["url", "promises", "fetch", "queryselector"], - "jsdoc": { - "additionalTagNames": { + settings: { + polyfills: ["url", "promises", "fetch", "queryselector"], + jsdoc: { + additionalTagNames: { // In case we need to extend - "customTags": [] + customTags: [] }, - "tagNamePreference": { - "arg": "param", - "return": "returns" + tagNamePreference: { + arg: "param", + return: "returns" }, - "allowOverrideWithoutParam": true, - "allowImplementsWithoutParam": true, - "allowAugmentsExtendsWithoutParam": true, + allowOverrideWithoutParam: true, + allowImplementsWithoutParam: true, + allowAugmentsExtendsWithoutParam: true, // For `jsdoc/check-examples` in `ash-nazg` - "matchingFileName": "dummy.md", - "rejectExampleCodeRegex": "^`", + matchingFileName: "dummy.md", + rejectExampleCodeRegex: "^`", } }, - "overrides": [ + overrides: [ // These would otherwise currently break because of these issues: // 1. `event:` https://github.com/eslint/doctrine/issues/221 and https://github.com/Kuniwak/jsdoctypeparser/pull/49 with https://github.com/Kuniwak/jsdoctypeparser/issues/47 // 1. `@implements`/`@augments`/`@extends`/`@override`: https://github.com/eslint/doctrine/issues/222 { - "files": [ + files: [ "test/utilities_test.js", "editor/svg-editor.js", "editor/svgcanvas.js", "editor/coords.js", "editor/extensions/ext-eyedropper.js", "editor/extensions/ext-webappfind.js" ], - "rules": { + rules: { "jsdoc/valid-types": "off", "valid-jsdoc": "off" } }, // Locales have no need for importing outside of SVG-Edit { - "files": [ + files: [ "editor/locale/lang.*.js", "editor/extensions/ext-locale/**", "docs/tutorials/ExtensionDocs.md" ], - "rules": { + rules: { "import/no-anonymous-default-export": ["off"] } }, @@ -59,15 +59,15 @@ module.exports = { // descriptive `svgEditor`; they also have no need for importing outside // of SVG-Edit { - "files": ["editor/extensions/**/ext-*.js"], - "rules": { + files: ["editor/extensions/**/ext-*.js"], + rules: { "consistent-this": ["error", "svgEditor"], "import/no-anonymous-default-export": ["off"] } }, // These browser files don't do importing or requiring { - "files": [ + files: [ "editor/svgpathseg.js", "editor/touch.js", "editor/typedefs.js", "editor/redirect-on-no-module-support.js", "editor/extensions/imagelib/index.js", @@ -77,7 +77,7 @@ module.exports = { "firefox-extension/handlers.js", "firefox-extension/content/svg-edit-overlay.js" ], - "rules": { + rules: { "import/unambiguous": ["off"] } }, @@ -85,8 +85,8 @@ module.exports = { // our use of `matchingFileName` in conjunction with // `jsdoc/check-examples` within `ash-nazg`) { - "files": ["**/*.md"], - "rules": { + files: ["**/*.md"], + rules: { "eol-last": ["off"], "no-console": ["off"], "no-undef": ["off"], @@ -99,56 +99,56 @@ module.exports = { }, // Dis-apply Node rules mistakenly giving errors with browser files { - "files": ["editor/**", "test/**"], - "rules": { + files: ["editor/**", "test/**"], + rules: { "node/no-unsupported-features/node-builtins": ["off"] } }, // We want console in tests! { - "files": ["test/**"], - "rules": { + files: ["test/**"], + rules: { "no-console": ["off"] } }, { // Node files - "files": [ + files: [ "docs/jsdoc-config.js", "build-html.js", "jsdoc-check-overly-generic-types.js", "rollup.config.js", "rollup-config.config.js" ], - "env": { - "node": true, + env: { + node: true, }, - "rules": { + rules: { "node/no-unpublished-import": ["off"], "node/no-unsupported-features/es-syntax": ["off"] } }, { // As consumed by jsdoc, cannot be expressed as ESM - "files": ["docs/jsdoc-config.js"], - "parserOptions": { - "sourceType": "script" + files: ["docs/jsdoc-config.js"], + parserOptions: { + sourceType: "script" }, - "rules": { + rules: { "import/no-commonjs": "off" } } ], - "rules": { + rules: { // Override these `ash-nazg/sauron` rules which are difficult for us // to apply at this time "capitalized-comments": ["off"], - "complexity": ["off"], + complexity: ["off"], "default-case": ["off"], "require-unicode-regexp": ["off"], "no-magic-numbers": ["off"], "no-warning-comments": ["off"], "max-len": ["off", { - "ignoreUrls": true, - "ignoreRegExpLiterals": true + ignoreUrls: true, + ignoreRegExpLiterals: true }] } };