Merge pull request #583 from SVG-Edit/issues/431

#431 Need help about image tags

src/editor/Editor.js

@@ -417,10 +417,21 @@ class Editor extends EditorStartup {
       $id("change_image_url").style.display = 'block';
     } else {
       // regular URL
-      this.svgCanvas.embedImage(url, function (dataURI) {
-        // Couldn't embed, so show warning
+      const self = this;
+      const promised = this.svgCanvas.embedImage(url);
+      // eslint-disable-next-line promise/catch-or-return
+      promised
+        .then( function (dataURI) {
+          // eslint-disable-next-line promise/always-return
           $id('url_notice').style.display = (!dataURI) ? 'block' : 'none';
-        this.defaultImageURL = url;
+          // switch into "select" mode if we've clicked on an element
+          self.svgCanvas.setMode('select');
+          self.svgCanvas.selectOnly(self.svgCanvas.getSelectedElems(), true);
+        }, function (error) {
+          // eslint-disable-next-line no-console
+          console.log("error =", error);
+          seAlert(self.i18next.t('tools.no_embed'));
+          self.svgCanvas.deleteSelectedElements();
         });
       $id("image_url").style.display = 'block';
       $id("change_image_url").style.display = 'none';

src/editor/panels/TopPanel.js

@@ -292,6 +292,7 @@ class TopPanel {
         $id("g_panel").style.display = 'block';
       }
       // siblings
+      if (elem.parentNode) {
         const selements = Array.prototype.filter.call(elem.parentNode.children, function(child){
           return child !== elem;
         });
@@ -299,6 +300,7 @@ class TopPanel {
           $id("a_panel").style.display = 'block';
           linkHref = this.editor.svgCanvas.getHref(elem.parentNode);
         }
+      }
 
       // Hide/show the make_link buttons
       $id('tool_make_link').style.display = (!linkHref) ? 'block' : 'none';

src/svgcanvas/svg-exec.js

@@ -651,7 +651,7 @@ export const embedImage = function (src) {
       resolve(svgContext_.getEncodableImages(src));
     });
     imgI.addEventListener("error", (e) => {
-      reject(new Error(`error loading image: ${e.currentTarget.attributes.src.value}`));
+      reject(`error loading image: ${e.currentTarget.attributes.src.value}`);
     });
     imgI.setAttribute('src', src);
   });