From ab00d37f2151abaaaf2372ccf62dbc5ce6f7c2d6 Mon Sep 17 00:00:00 2001 From: Timo Dittmann Date: Wed, 23 Dec 2020 13:44:48 +0100 Subject: [PATCH] - Fix #450: Cancel buttons are now working --- src/editor/svgedit.js | 38 ++++++++++++++++++-------------------- 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/src/editor/svgedit.js b/src/editor/svgedit.js index 4c02dfe4..5d41809c 100644 --- a/src/editor/svgedit.js +++ b/src/editor/svgedit.js @@ -5375,6 +5375,7 @@ editor.init = () => { '#tool_source_cancel', '#tool_docprops_cancel', '#tool_prefs_cancel', '.overlay' ]; + /* eslint-disable jsdoc/require-property */ /** * Associate all button actions as well as non-button keyboard shortcuts. @@ -5401,20 +5402,13 @@ editor.init = () => { const toolButtons = [ {sel: '#tool_select', fn: clickSelect, evt: 'click', key: ['V', true]}, {sel: '#tool_fhpath', fn: clickFHPath, evt: 'click', key: ['Q', true]}, - {sel: '#tool_line', fn: clickLine, evt: 'click', key: ['L', true], - parent: '#tools_line', prepend: true}, - {sel: '#tool_rect', fn: clickRect, evt: 'mouseup', - key: ['R', true], parent: '#tools_rect', icon: 'rect'}, - {sel: '#tool_square', fn: clickSquare, evt: 'mouseup', - parent: '#tools_rect', icon: 'square'}, - {sel: '#tool_fhrect', fn: clickFHRect, evt: 'mouseup', - parent: '#tools_rect', icon: 'fh_rect'}, - {sel: '#tool_ellipse', fn: clickEllipse, evt: 'mouseup', - key: ['E', true], parent: '#tools_ellipse', icon: 'ellipse'}, - {sel: '#tool_circle', fn: clickCircle, evt: 'mouseup', - parent: '#tools_ellipse', icon: 'circle'}, - {sel: '#tool_fhellipse', fn: clickFHEllipse, evt: 'mouseup', - parent: '#tools_ellipse', icon: 'fh_ellipse'}, + {sel: '#tool_line', fn: clickLine, evt: 'click', key: ['L', true], parent: '#tools_line', prepend: true}, + {sel: '#tool_rect', fn: clickRect, evt: 'mouseup', key: ['R', true], parent: '#tools_rect', icon: 'rect'}, + {sel: '#tool_square', fn: clickSquare, evt: 'mouseup', parent: '#tools_rect', icon: 'square'}, + {sel: '#tool_fhrect', fn: clickFHRect, evt: 'mouseup', parent: '#tools_rect', icon: 'fh_rect'}, + {sel: '#tool_ellipse', fn: clickEllipse, evt: 'mouseup', key: ['E', true], parent: '#tools_ellipse', icon: 'ellipse'}, + {sel: '#tool_circle', fn: clickCircle, evt: 'mouseup', parent: '#tools_ellipse', icon: 'circle'}, + {sel: '#tool_fhellipse', fn: clickFHEllipse, evt: 'mouseup', parent: '#tools_ellipse', icon: 'fh_ellipse'}, {sel: '#tool_path', fn: clickPath, evt: 'click', key: ['P', true]}, {sel: '#tool_text', fn: clickText, evt: 'click', key: ['T', true]}, {sel: '#tool_image', fn: clickImage, evt: 'mouseup'}, @@ -5443,8 +5437,10 @@ editor.init = () => { }, hidekey: true }, - {sel: dialogSelectors.join(','), fn: cancelOverlays, evt: 'click', - key: ['esc', false, false], hidekey: true}, + {sel: '#tool_source_cancel', fn: cancelOverlays, evt: 'click', key: ['esc', false, false], hidekey: true}, + {sel: '#tool_docprops_cancel', fn: cancelOverlays, evt: 'click', key: ['esc', false, false], hidekey: true}, + {sel: '#tool_prefs_cancel', fn: cancelOverlays, evt: 'click', key: ['esc', false, false], hidekey: true}, + {sel: '.overlay', fn: cancelOverlays, evt: 'click', key: ['esc', false, false], hidekey: true}, {sel: '#tool_source_save', fn: saveSourceEditor, evt: 'click'}, {sel: '#tool_docprops_save', fn: saveDocProperties, evt: 'click'}, {sel: '#tool_docprops', fn: showDocProperties, evt: 'click'}, @@ -5453,8 +5449,8 @@ editor.init = () => { {sel: '#tool_editor_homepage', fn: openHomePage, evt: 'click'}, {sel: '#tool_open', fn () { window.dispatchEvent(new CustomEvent('openImage')); }, evt: 'click'}, {sel: '#tool_import', fn () { window.dispatchEvent(new CustomEvent('importImage')); }, evt: 'click'}, - {sel: '#tool_delete,#tool_delete_multi', fn: deleteSelected, - evt: 'click', key: ['del/backspace', true]}, + {sel: '#tool_delete', fn: deleteSelected, evt: 'click', key: ['del/backspace', true]}, + {sel: '#tool_delete_multi', fn: deleteSelected, evt: 'click', key: ['del/backspace', true]}, {sel: '#tool_reorient', fn: reorientPath, evt: 'click'}, {sel: '#tool_node_link', fn: linkControlPoints, evt: 'click'}, {sel: '#tool_node_clone', fn: clonePathNode, evt: 'click'}, @@ -5464,10 +5460,12 @@ editor.init = () => { {sel: '#tool_move_top', fn: moveToTopSelected, evt: 'click', key: 'ctrl+shift+]'}, {sel: '#tool_move_bottom', fn: moveToBottomSelected, evt: 'click', key: 'ctrl+shift+['}, {sel: '#tool_topath', fn: convertToPath, evt: 'click'}, - {sel: '#tool_make_link,#tool_make_link_multi', fn: makeHyperlink, evt: 'click'}, + {sel: '#tool_make_link', fn: makeHyperlink, evt: 'click'}, + {sel: '#tool_make_link_multi', fn: makeHyperlink, evt: 'click'}, {sel: '#tool_undo', fn: clickUndo, evt: 'click'}, {sel: '#tool_redo', fn: clickRedo, evt: 'click'}, - {sel: '#tool_clone,#tool_clone_multi', fn: clickClone, evt: 'click', key: ['D', true]}, + {sel: '#tool_clone', fn: clickClone, evt: 'click', key: ['D', true]}, + {sel: '#tool_clone_multi', fn: clickClone, evt: 'click', key: ['D', true]}, {sel: '#tool_group_elements', fn: clickGroup, evt: 'click', key: ['G', true]}, {sel: '#tool_ungroup', fn: clickGroup, evt: 'click'}, {sel: '#tool_unlink_use', fn: clickGroup, evt: 'click'},