- Fix: Save broken on Firefox (since FF version?)

- Docs: Mention potentially more frequent release schedule
- Docs (ReleaseInstructions): Update per new testing; update
  `grep-doc` -> `types-doc` and indicate current failing status; indicate
  when `build-doc` will be used; clarify `npm pack`
- npm: Add newly renamed `jsdoc-check-overly-generic-types.js` to ignore
- npm: Bump to 3.1.1

.npmignore

@@ -4,5 +4,5 @@ test
 
 .github/ISSUE_TEMPLATE/bug_report.md
 build
-grep-jsdoc.js
+jsdoc-check-overly-generic-types.js
 lgtm.yml

CHANGES.md

@@ -1,10 +1,15 @@
-# ?
+# 3.1.1
 
+- Fix: Save broken on Firefox (since FF version?)
 - Docs (ReleaseInstructions): Clarify build instructions for release
+- Docs (ReleaseInstructions): Update per new testing; update
+  `grep-doc` -> `types-doc` and indicate current failing status; indicate
+  when `build-doc` will be used; clarify `npm pack`
 - Docs: For clarity, rename `grep-jsdoc.js` to
   `jsdoc-check-overly-generic-types.js`
 - Docs: Move `GenericCallback` to `typedefs.js` for possible (if unlikely)
   reuse
+- Docs: Mention potentially more frequent release schedule
 - npm: Update "grep-doc" to "types-doc" for greater clarity
 - npm: Per convention, switch Node-based (headless browser) testing script to
     `npm test` and change the browser tests to "browser-test"

README.md

@@ -92,6 +92,7 @@ incorporating SVGEdit.
 
 ## Recent news
 
+- 2018-10-25 Published 3.1.1 (Fix for saving SVG on Firefox)
 - 2018-10-24 Published 3.1.0 (Redirect on modular page for non-module-support;
   versions document (for migrating))
 - 2018-10-22 Published 3.0.1 (Revert fix affecting polygon selection)

dist/index-es.js

@@ -29385,6 +29385,9 @@ editor.init = function () {
     var a = document.createElement('a');
     a.href = 'data:image/svg+xml;base64,' + encode64(svg);
     a.download = 'icon.svg';
+    a.style = 'display: none;';
+    document.body.append(a); // Need to append for Firefox
+
     a.click(); // Alert will only appear the first time saved OR the
     //   first time the bug is encountered
 

dist/index-umd.js

@@ -29391,6 +29391,9 @@
       var a = document.createElement('a');
       a.href = 'data:image/svg+xml;base64,' + encode64(svg);
       a.download = 'icon.svg';
+      a.style = 'display: none;';
+      document.body.append(a); // Need to append for Firefox
+
       a.click(); // Alert will only appear the first time saved OR the
       //   first time the bug is encountered
 

docs/ReleaseInstructions.md

@@ -2,18 +2,24 @@
 
 ## Prepare
 
-1. `npm test` - Ensure build steps occur and tests are passing
+1. `npm run browser-test` - Ensure build steps occur and tests are passing
-1. `npm run build-doc` - Ensure JSDoc can build and is available for site build
+1. `npm test` - This should also be run, though currently accessibility tests
-1. `npm run grep-doc` - For JSDoc, we ensure that a minimum of generic types
+    are failing
+1. `npm run build-doc` - Ensure JSDoc can build and is available for site
+    build (though not added to `master`, will be copied over in `gh-pages`
+    steps and used in `npm publish` step).
+1. `npm run types-doc` - For JSDoc, we ensure that a minimum of generic types
     have been added (e.g., "number" should instead be "Float" or "Array",
     and "object", "function", or "array" should be replaced by more specific
     `@interface`s, `@typdef`s, or `@callback`. Deriving types can use
     `PlainObject` or `GenericArray` to indicate the simple base type was
     intentional. `*` should also be checked. The script reports all failing
-    matches within `editor`. There should be none.
+    matches within `editor`. There should be none (there is currently one
-1. Preview which files will be included once published (taking into
+    due to our needing to move the file to its own module).
-    account `.npmignore`), by using `npm pack` (taking care to remove
+1. `npm pack` to preview which files will be included once published and
-    the `.tgz` tarball file that it creates).
+    taking into account `.npmignore`. Take care to remove the `.tgz` tarball
+    file that it creates so it is not itself included during the
+    publishing step.
 
 ## Update the main project
 <!--

docs/versions/3.0.0.md

@@ -9,6 +9,9 @@ Please see the CHANGES file (or the Git history or Github tracker) for more
 detailed descriptions of individual changes than that provided by the
 below summaries.
 
+Concomitant with switching to npm (semantic) versioning, future releases
+should be added for any changes on a more frequent schedule.
+
 ## Breaking changes
 
 There were also the following breaking changes. Not included among these are

editor/svg-editor.js

@@ -1702,12 +1702,15 @@ editor.init = function () {
     const a = document.createElement('a');
     a.href = 'data:image/svg+xml;base64,' + Utils.encode64(svg);
     a.download = 'icon.svg';
+    a.style = 'display: none;';
+    document.body.append(a); // Need to append for Firefox
 
     a.click();
 
     // Alert will only appear the first time saved OR the
     //   first time the bug is encountered
     let done = $.pref('save_notice_done');
+
     if (done !== 'all') {
       let note = uiStrings.notification.saveFromBrowser.replace('%s', 'SVG');
       // Check if FF and has <defs/>

editor/xdomain-svgedit-config-iife.js

@@ -29388,6 +29388,9 @@
       var a = document.createElement('a');
       a.href = 'data:image/svg+xml;base64,' + encode64(svg);
       a.download = 'icon.svg';
+      a.style = 'display: none;';
+      document.body.append(a); // Need to append for Firefox
+
       a.click(); // Alert will only appear the first time saved OR the
       //   first time the bug is encountered
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "svgedit",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "svgedit",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "Powerful SVG-Editor for your browser ",
   "main": "dist/index-umd.js",
   "module": "dist/index-es.js",

svgedit-config-iife.js

@@ -29388,6 +29388,9 @@
       var a = document.createElement('a');
       a.href = 'data:image/svg+xml;base64,' + encode64(svg);
       a.download = 'icon.svg';
+      a.style = 'display: none;';
+      document.body.append(a); // Need to append for Firefox
+
       a.click(); // Alert will only appear the first time saved OR the
       //   first time the bug is encountered