From cd5f80eac09b67ab6239a32ec2cfdd73e40ea5a5 Mon Sep 17 00:00:00 2001
From: Brett Zamir <brettz9@yahoo.com>
Date: Fri, 10 Jan 2020 09:34:44 +0800
Subject: [PATCH] - Refactoring: Add favicon no-op to suppress favicon 404s
 until   loaded dynamically (might make configurable in future)

---
 CHANGES.md                        | 2 ++
 editor/svg-editor-es.html         | 4 ++++
 editor/svg-editor.html            | 4 ++++
 editor/xdomain-svg-editor-es.html | 4 ++++
 editor/xdomain-svg-editor.html    | 4 ++++
 5 files changed, 18 insertions(+)

diff --git a/CHANGES.md b/CHANGES.md
index 285b39c7..1b0f3a3e 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -46,6 +46,8 @@
 - Refactoring: Switch from `$.param.querystring` to `URL`
 - Refactoring: Ensure file-global jsdoc tags are at beginning of file
 - Refactoring: Move `build-html` to `build` directory
+- Refactoring: Add favicon no-op to suppress favicon 404s until
+  loaded dynamically (might make configurable in future)
 - Linting (ESLint): Simplify regexes
 - Linting (ESLint): Replace `innerHTML` with `textContent` from old demo
 - Linting (ESLint): Update as per latest ash-nazg
diff --git a/editor/svg-editor-es.html b/editor/svg-editor-es.html
index 5114efcf..296b639d 100644
--- a/editor/svg-editor-es.html
+++ b/editor/svg-editor-es.html
@@ -6,6 +6,10 @@
     <meta name="viewport"
       content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
     <meta name="apple-mobile-web-app-capable" content="yes" />
+
+    <!-- No-op until loaded dynamically (could make configurable) -->
+    <link rel="shortcut icon" href="data:image/x-icon;," type="image/x-icon" />
+
     <!-- STYLESHEETS (others loaded dynamically) -->
     <style id="styleoverrides" media="screen"></style>
 
diff --git a/editor/svg-editor.html b/editor/svg-editor.html
index 469e2d17..5c208ea8 100644
--- a/editor/svg-editor.html
+++ b/editor/svg-editor.html
@@ -7,6 +7,10 @@
     <meta name="viewport"
       content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
     <meta name="apple-mobile-web-app-capable" content="yes" />
+
+    <!-- No-op until loaded dynamically (could make configurable) -->
+    <link rel="shortcut icon" href="data:image/x-icon;," type="image/x-icon" />
+
     <!-- STYLESHEETS (others loaded dynamically) -->
     <style id="styleoverrides" media="screen"></style>
 
diff --git a/editor/xdomain-svg-editor-es.html b/editor/xdomain-svg-editor-es.html
index f4d6baef..bd624504 100644
--- a/editor/xdomain-svg-editor-es.html
+++ b/editor/xdomain-svg-editor-es.html
@@ -7,6 +7,10 @@
     <meta name="viewport"
       content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
     <meta name="apple-mobile-web-app-capable" content="yes" />
+
+    <!-- No-op until loaded dynamically (could make configurable) -->
+    <link rel="shortcut icon" href="data:image/x-icon;," type="image/x-icon" />
+
     <!-- STYLESHEETS (others loaded dynamically) -->
     <style id="styleoverrides" media="screen"></style>
 
diff --git a/editor/xdomain-svg-editor.html b/editor/xdomain-svg-editor.html
index d7b76865..2a97354b 100644
--- a/editor/xdomain-svg-editor.html
+++ b/editor/xdomain-svg-editor.html
@@ -7,6 +7,10 @@
     <meta name="viewport"
       content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
     <meta name="apple-mobile-web-app-capable" content="yes" />
+
+    <!-- No-op until loaded dynamically (could make configurable) -->
+    <link rel="shortcut icon" href="data:image/x-icon;," type="image/x-icon" />
+
     <!-- STYLESHEETS (others loaded dynamically) -->
     <style id="styleoverrides" media="screen"></style>