Commit Graph

15 Commits (af42d1fb0f6a58a354964149925b105e6f462557)

Author SHA1 Message Date
Brett Zamir d84f39cb3f - Docs (JSDoc): Further on preferring `void` 2019-04-16 08:59:53 +08:00
Brett Zamir 7c470e9909 - Linting (ESLint): Stricter rules (or switch to warning)
- Breaking internal API change: `updateGripCursor` moved to be class method of Selector rather than instance method
- Breaking internal API change: `subpathIsClosed` moved to be class method of `Path` rather than instance method
- Refactoring: Reuse utilities base64 encoder for SVG icons plugin
- Docs (JSDoc): Fix return of the `mouseUp` (can also be an object) and `mouseDown` (may also be a boolean) of `pathActions`; other JSDoc additions/improvements
2018-11-08 14:42:48 +08:00
Brett Zamir ae2394f086 (INCOMPLETE: ES6 Module conversion and linting)
- Breaking change: Require `new` with `EmbeddedSVGEdit` (allows us to use `class` internally)
- Breaking change: If `svgcanvas.setUiStrings` must now be called if not using editor in order
    to get strings (for sake of i18n) (and if using path.js alone, must also have its `setUiStrings` called)
- Breaking change (ext-overview-window): Avoid global `overviewWindowGlobals`
- Breaking change (ext-imagelib): Change to object-based encoding for namespacing of
    messages (though keep stringifying/parsing ourselves until we remove IE9 support)
- Breaking change: Rename `jquery.js` to `jquery.min.js`
- Breaking change: Remove `scoped` attribute from `style`; it is now deprecated and
    obsolete; also move to head (after other stylesheets)
- Enhancement: Make SpinButton plugin independent of SVGEdit via
    generic state object for tool_scale
- Enhancement: Remove now unused Python l10n scripts (#238)
- Enhancement: ES6 Modules (including jQuery plugins but not jQuery)
- Enhancement: Further JSDoc (incomplete)
- Enhancement (Optimization): Compress images using imageoptim (and add
    npm script) (per #215)
- Fix: i18nize path.js strings and canvas notifications
- Fix: Attempt i18n for ext-markers
- Refactoring (ext-storage): Move locale info to own file imported by the extension (toward modularity; still should be split into separate files by language and *dynamically* imported, but we'll wait for better `import` support to refactor this)
- Refactoring: For imagelib, add local jQuery copy (using old 1.4.4 as had
    been using from server)
- Refactoring: For MathJax, add local copy (using old 2.3 as had been using from
    server); server had not been working
- Refactoring: Remove `use strict` (implicit in modules)
- Refactoring: Remove trailing whitespace, fix some code within comments
- Refactoring: Expect `jQuery` global rather than `$` for better modularity
    (also to adapt line later once available via `import`)
- Refactoring: Prefer `const` (and then `let`)
- Refactoring: Add block scope keywords closer to first block in which they appear
- Refactoring: Use ES6 `class`
- Refactoring `$.isArray` -> `Array.isArray` and avoid some other jQuery core methods
    with simple VanillaJS replacements
- Refactoring: Use abbreviated object property syntax
- Refactoring: Object destructuring
- Refactoring: Remove `uiStrings` contents in svg-editor.js (obtains from locale)
- Refactoring: Add favicon to embedded API file
- Refactoring: Use arrow functions for brief functions (incomplete)
- Refactoring: Use `Array.prototype.includes`/`String.prototype.includes`;
    `String.prototype.startsWith`, `String.prototype.trim`
- Refactoring: Remove now unnecessary svgutils do/while resetting of variables
- Refactoring: Use shorthand methods for object literals (avoid ": function")
- Refactoring: Avoid quoting object property keys where unnecessary
- Refactoring: Just do truthy/falsey check for lengths in place of comparison to 0
- Refactoring (Testing): Avoid jQuery usage within most test files (defer script,
    also in preparation for future switch to ES6 modules for tests)
- Refactoring: Make jpicker variable declaration indent bearable
- Refactoring (Linting): Finish svgcanvas.js
- Docs: Mention in comment no longer an entry file as before
- Docs: Migrate old config, extensions, and FAQ docs
- Licensing: Indicate MIT is license type of rgbcolor; rename/add license file name for
    jgraduate and screencast to reflect type (Apache 2.0); rename file to reflect it
    contains license information (of type MIT) for Raphael icons
2018-05-22 18:02:57 +08:00
Brett Zamir 52353c6321 - Further convert tabs -> 2 spaces in JS code comments (except in test performance
file where used for alignment though use tab escape within JS), CSS
    (including comments), PHP, SVG, JSON, XUL
- Remove extra spaces in svgcanvas.js, ext-connector.js
2018-05-18 14:41:43 +08:00
Brett Zamir 4bfbaacb5e - Complete conversion to 2-spaces, fixing issue #37 (also removed some extra/misplaced tabs/spaces in process) 2018-05-18 14:23:36 +08:00
Brett Zamir 5894398c36 - Linting: ESLint (or ignore) JavaScript files; unfinished: editor/jgraduate and editor/extensions folders, editor/ (root), test/ (root) HTML
- Fix: An apparent bug in jquery.svgicons.js whereby a variable `holder` was declared in too nested of a scope
- Fix: `addBezierCurve` in canvg.js had undeclared `i`
- Fix: Undeclared variable in opera widget
- Fix: Screencast `showNotes`
2018-05-13 18:47:00 +08:00
Pavol Rusnak c0273beb31 fix build of firefox extension and opera widget again
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@1696 eee81c28-f429-11dd-99c0-75d572ba1ddd
2010-09-01 09:20:05 +00:00
Jeff Schiller c7e65bb77d Minor updates to branding to update to pre-2.5
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@1146 eee81c28-f429-11dd-99c0-75d572ba1ddd
2010-01-04 21:15:01 +00:00
Narendra Sisodiya 5636cd3f73 Fixing Bug 189 , adding icon in status bar in firefox
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@622 eee81c28-f429-11dd-99c0-75d572ba1ddd
2009-09-10 19:13:40 +00:00
Narendra Sisodiya 3ce957efe9 correcting upper version in addon
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@611 eee81c28-f429-11dd-99c0-75d572ba1ddd
2009-09-08 20:05:44 +00:00
Pavol Rusnak 4043d459dd create one Makefile in the top root directory (WIP - need to remove build path from resulting archives)
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@563 eee81c28-f429-11dd-99c0-75d572ba1ddd
2009-09-04 16:10:50 +00:00
Alexis Deveria 6bd6d0746e Fixed comment in FF/Opera hander files, fixed bugs for Firefox extension
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@469 eee81c28-f429-11dd-99c0-75d572ba1ddd
2009-08-25 18:22:43 +00:00
Alexis Deveria baf9f75982 Possibly fixed issue 99 and issue 108 by setting up an external handler function. Moved Opera references to seperate file and reprocessed thinker.li's patch to also use a use separate file
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@468 eee81c28-f429-11dd-99c0-75d572ba1ddd
2009-08-25 16:35:57 +00:00
Pavol Rusnak 2eea448e9a replaced scripts with makefile (call make all to build)
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@432 eee81c28-f429-11dd-99c0-75d572ba1ddd
2009-08-21 14:03:39 +00:00
Jeff Schiller dfd747f9c5 Check in patch from Thinker Li to adapt SVG-edit into a Firefox extension
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@429 eee81c28-f429-11dd-99c0-75d572ba1ddd
2009-08-21 12:33:56 +00:00