From c4d98afc6869ef83807163a12a516d90675da8b8 Mon Sep 17 00:00:00 2001
From: Andrew Port <andyaport@gmail.com>
Date: Sat, 1 Apr 2023 15:26:22 -0400
Subject: [PATCH 1/2] add test for issue 198

---
 test/test_svg2paths.py | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/test/test_svg2paths.py b/test/test_svg2paths.py
index fe2507a..4aec225 100644
--- a/test/test_svg2paths.py
+++ b/test/test_svg2paths.py
@@ -3,8 +3,11 @@ import unittest
 from svgpathtools import Path, Line, Arc, svg2paths, svgstr2paths
 from io import StringIO
 from io import open  # overrides build-in open for compatibility with python2
+import os
 from os.path import join, dirname
 from sys import version_info
+import tempfile
+import shutil
 
 from svgpathtools.svg_to_paths import rect2pathd
 
@@ -57,6 +60,26 @@ class TestSVG2Paths(unittest.TestCase):
         self.assertTrue(path_circle==path_circle_correct)
         self.assertTrue(path_circle.isclosed())
 
+        # test for issue #198 (circles not being closed)
+        svg = u"""<?xml version="1.0" encoding="UTF-8"?>
+        <svg xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg" width="40mm" height="40mm" 
+          viewBox="0 0 40 40" version="1.1">
+            
+          <g id="layer">
+            <circle id="c1" cx="20.000" cy="20.000" r="11.000" />
+            <circle id="c2" cx="20.000" cy="20.000" r="5.15" />
+          </g>
+        </svg>"""
+        tmpdir = tempfile.mkdtemp()
+        svgfile = os.path.join(tmpdir, 'test.svg')
+        with open(svgfile, 'w') as f:
+            f.write(svg)
+        paths, _ = svg2paths(svgfile)
+        self.assertEqual(len(paths), 2)
+        self.assertTrue(paths[0].isclosed())
+        self.assertTrue(paths[1].isclosed())
+        shutil.rmtree(tmpdir)
+
     def test_rect2pathd(self):
         non_rounded = {"x":"10", "y":"10", "width":"100","height":"100"}
         self.assertEqual(rect2pathd(non_rounded), 'M10.0 10.0 L 110.0 10.0 L 110.0 110.0 L 10.0 110.0 z')
@@ -107,3 +130,7 @@ class TestSVG2Paths(unittest.TestCase):
             paths, _ = svgstr2paths(file_content)
 
             self.assertEqual(len(paths), 2)
+
+
+if __name__ == '__main__':
+    unittest.main()

From 4f5d8f3bf21bb9592e478b8af3daa84d87174589 Mon Sep 17 00:00:00 2001
From: Andrew Port <andyaport@gmail.com>
Date: Sat, 1 Apr 2023 15:30:04 -0400
Subject: [PATCH 2/2] fix issue-198; circles parsing to non-closed paths

---
 svgpathtools/svg_to_paths.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/svgpathtools/svg_to_paths.py b/svgpathtools/svg_to_paths.py
index a8decba..65591af 100644
--- a/svgpathtools/svg_to_paths.py
+++ b/svgpathtools/svg_to_paths.py
@@ -51,7 +51,7 @@ def ellipse2pathd(ellipse):
     d += 'a' + str(rx) + ',' + str(ry) + ' 0 1,0 ' + str(2 * rx) + ',0'
     d += 'a' + str(rx) + ',' + str(ry) + ' 0 1,0 ' + str(-2 * rx) + ',0'
 
-    return d
+    return d + 'z'
 
 
 def polyline2pathd(polyline, is_polygon=False):